[Kde-pim] Review Request 119127: Outline for reply and forward
laurent Montel
montel at kde.org
Sat Jul 5 12:52:15 BST 2014
Le samedi 5 juillet 2014 10:46:32 Abhijeet Nikam a écrit :
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119127/
> -----------------------------------------------------------
>
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> Outline for Adding the identity, replyTo, forward to the composer file. It
> didn't seem to compile until I added kdepim in the cmakelists.txt and
> messagecomposer/ in the header. I want to know whether this approach is
> right of using kdepim identity and message factory? For now I am using a
> test createplaintextmessage(), which has to be replaced by akonadi item.
>
>
> Diffs
> -----
>
> messagecore/misc/mdnstateattribute.h c609665
Hi,
Please adapt cmakelists.txt from mobile/api/mail, and not change
mdnstateattribute.h it compiles fine in kdepim so not necessary to change this
includes
PS: I can’t log in reviewboard so I write in ML.
Regards
> mobile/api/mail/CMakeLists.txt bc1aebe
> mobile/api/mail/composer.h b731287
> mobile/api/mail/composer.cpp dc750e8
>
> Diff: https://git.reviewboard.kde.org/r/119127/diff/
>
>
> Testing
> -------
>
> Yet to be done.
>
>
> Thanks,
>
> Abhijeet Nikam
>
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/
--
Laurent Montel | laurent.montel at kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list