[Kde-pim] Review Request 119480: Add autoconfiguration for kolab servers

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119480/#review63189
-----------------------------------------------------------



accountwizard/ispdb/autoconfigkolabfreebusy.h
<https://git.reviewboard.kde.org/r/119480/#comment43955>

    initialize directly during create constructor
    as
    freebusy()
     : port(80),
       aut...
       
       
    {
    }



accountwizard/ispdb/autoconfigkolabfreebusy.cpp
<https://git.reviewboard.kde.org/r/119480/#comment43956>

    const



accountwizard/ispdb/autoconfigkolabfreebusy.cpp
<https://git.reviewboard.kde.org/r/119480/#comment43957>

    const



accountwizard/ispdb/autoconfigkolabfreebusy.cpp
<https://git.reviewboard.kde.org/r/119480/#comment43958>

    ++i



accountwizard/ispdb/autoconfigkolabldap.h
<https://git.reviewboard.kde.org/r/119480/#comment43959>

    save as previous struct initialize value directly.



accountwizard/ispdb/autoconfigkolabldap.cpp
<https://git.reviewboard.kde.org/r/119480/#comment43960>

    ++i



accountwizard/ispdb/ispdb.h
<https://git.reviewboard.kde.org/r/119480/#comment43962>

    initialize boolean in constructor as for other struct



accountwizard/ispdb/ispdb.cpp
<https://git.reviewboard.kde.org/r/119480/#comment43963>

    const



accountwizard/ispdb/ispdb.cpp
<https://git.reviewboard.kde.org/r/119480/#comment43964>

    l.isEmpty()



accountwizard/ispdb/ispdb.cpp
<https://git.reviewboard.kde.org/r/119480/#comment43965>

    void Ispdb::set....()
    {
    ...
    }



accountwizard/ispdb/tests/autoconfigkolabfreebusy.cpp
<https://git.reviewboard.kde.org/r/119480/#comment43968>

    coding style { at new line



accountwizard/ispdb/tests/autoconfigkolabfreebusy.cpp
<https://git.reviewboard.kde.org/r/119480/#comment43969>

    same here and other.


- Laurent Montel


On juil. 26, 2014, 10:30 matin, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119480/
> -----------------------------------------------------------
> 
> (Updated juil. 26, 2014, 10:30 matin)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> For autoconfigure more types kolab has improved the autoconfig format for different types (freebusy and ldap) [for format see accountwizard/ispdb/tests/data/*.xml]. 
> 
> Unfortunately mozilla forgotten to define the identity element in for mailservers, so kolab step into it and defind a kind of this element. To be possible to handle different kind ( I no other type till now). We add the type and version parameter for this element. I'm also d'accord to rename the type to somthing non kolab specific.
> 
> The gerneral handling for autoconfig for kolab is a bit improved:
> 1. ask the server the normal way ( http without auth)
> 2. if the server answer with 401 than ask again with https + auth
> 
> * open issue: publish kolab format at kolab wiki
> * add a site at userbase.kde.org about the identity part and link to kolab wiki
> 
> 
> Diffs
> -----
> 
>   accountwizard/ispdb/tests/data/ldap.xml PRE-CREATION 
>   accountwizard/ispdb/tests/errorserver.py PRE-CREATION 
>   accountwizard/ispdb/tests/ispdbtest.cpp PRE-CREATION 
>   accountwizard/ispdb/tests/data/autoconfig.xml PRE-CREATION 
>   accountwizard/ispdb/tests/data/freebusy.xml PRE-CREATION 
>   accountwizard/ispdb/CMakeLists.txt a2e2be41b3fa71998716a81390bebdbf398e1641 
>   accountwizard/ispdb/autoconfigkolabfreebusy.h PRE-CREATION 
>   accountwizard/ispdb/autoconfigkolabfreebusy.cpp PRE-CREATION 
>   accountwizard/ispdb/autoconfigkolabldap.h PRE-CREATION 
>   accountwizard/ispdb/autoconfigkolabldap.cpp PRE-CREATION 
>   accountwizard/ispdb/autoconfigkolabmail.h PRE-CREATION 
>   accountwizard/ispdb/autoconfigkolabmail.cpp PRE-CREATION 
>   accountwizard/ispdb/ispdb.h c29ef6a5757b2ad4ed3fbd1829aa3908b31d26c0 
>   accountwizard/ispdb/ispdb.cpp ddc16646146edef71c20f555e6b9a121d455316e 
>   accountwizard/ispdb/tests/CMakeLists.txt PRE-CREATION 
>   accountwizard/ispdb/tests/autoconfigkolabfreebusy.cpp PRE-CREATION 
>   accountwizard/ispdb/tests/autoconfigkolabldaptest.cpp PRE-CREATION 
>   accountwizard/ispdb/tests/autoconfigkolabmailtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119480/diff/
> 
> 
> Testing
> -------
> 
> written tests and run them successfully.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/