[Kde-pim] Review Request 119434: Per attendee customization of email [2] - DialogInterception for IncienceChanger

Laurent Montel montel at kde.org
Thu Jul 24 15:28:59 BST 2014



> On juil. 24, 2014, 2:08 après-midi, Laurent Montel wrote:
> > akonadi/calendar/itiphandler.h, line 135
> > <https://git.reviewboard.kde.org/r/119434/diff/2/?file=292405#file292405line135>
> >
> >     We can't add new virtual function in public api
> >     it's BIC
> 
> Sandro Knauß wrote:
>     This class MessageQueueJobFactory is completly new and is/was added within this patch series.

Indeed I didn't see the @since 4.15


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119434/#review63067
-----------------------------------------------------------


On juil. 24, 2014, 1:39 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119434/
> -----------------------------------------------------------
> 
> (Updated juil. 24, 2014, 1:39 après-midi)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> To be able to customize the emails per attendee from an iTip event. The dialogs opened by IncidenceChange has to be interceptable. You can see the both changeset in the dev/individual_mail2 branch.
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/incidencechanger.cpp aafa8d5158c29ddd92502ef86c49abaab514e52e 
>   akonadi/calendar/incidencechanger_p.h 82bdfa1d424fb847509828a04cf7ff3194dca507 
>   akonadi/calendar/itiphandler.h 5c581e7200f30efc69124e17306e9498a7e7589e 
>   akonadi/calendar/itiphandler.cpp 2b721999a7219e5dc5cf51b944fa75e502eafb17 
>   akonadi/calendar/itiphandler_p.h 35e895a54ea16ba2708ce0fe9632758f754d612c 
>   akonadi/calendar/itiphandler_p.cpp e62b72bf4bfb041c24598774fe028dbee0d7984d 
>   akonadi/calendar/itiphandlerhelper_p.h 11bc6de05cba8a17d55aba4a0f5514a3aafdac35 
>   akonadi/calendar/itiphandlerhelper_p.cpp ee3b68a0eeff66255069033ea722b3f327dad65a 
> 
> Diff: https://git.reviewboard.kde.org/r/119434/diff/
> 
> 
> Testing
> -------
> 
> run multiple times kincidenceeditor and korganizer to test and run itiphelpertest and mailclienttest.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list