[Kde-pim] Review Request 119080: fix timezone config in calendar view

[Sergio Luis Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119080/#review62399
-----------------------------------------------------------


Can you create an enum, such as:

enum {
    TimeZoneName = Qt::UserRole
};


And use the enumerator instead of Qt::UserRole, so one understands it easier when reading

- Sergio Luis Martins


On July 2, 2014, 5:38 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119080/
> -----------------------------------------------------------
> 
> (Updated July 2, 2014, 5:38 a.m.)
> 
> 
> Review request for KDEPIM and Sergio Luis Martins.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> old implementation uses i18n string in return value, which will make timezone configuration not working for other language, this commit uses Qt::UserRole to store the timezone name information.
> 
> 
> Diffs
> -----
> 
>   calendarviews/agenda/timescaleconfigdialog.cpp 2dbe3e0 
> 
> Diff: https://git.reviewboard.kde.org/r/119080/diff/
> 
> 
> Testing
> -------
> 
> change timezone under zh_CN now works.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/