[Kde-pim] Review Request 119236: Tagsupport for knutresource

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119236/#review62308
-----------------------------------------------------------

Ship it!


Just please look at the default type before comitting.


akonadi/tests/unittestenv/kdehome/testdata-res1.xml
<https://git.reviewboard.kde.org/r/119236/#comment43293>

    Could the default tag be of type "PLAIN"? It's the default basic type of Akonadi::Tag, I don't see a need to introduce another type even for testing purposes.


- Dan Vrátil


On July 14, 2014, 4:42 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119236/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 4:42 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Tagsupport for knutresource
> 
> 
> Diffs
> -----
> 
>   akonadi/tests/testresource/knutresource.cpp 2e61dc735ebc86c247aee1710b52f512ce55793a 
>   akonadi/tests/unittestenv/kdehome/testdata-res1.xml 638904cda9e76626a20ec384c2e31c18a6b9d53a 
>   akonadi/xml/akonadi-xml.xsd 4dba490443aad66ea5157aeccca42e4c87eff19e 
>   akonadi/xml/format_p.h 914479777f4ef4a8caf5410832037204a3353185 
>   akonadi/xml/xmldocument.h 0f768cce4e346c18c1ebe0b43f07b49158d6c24d 
>   akonadi/xml/xmldocument.cpp 0c30086345e5bd39a398e525b37d2b6dcfeaccf5 
>   akonadi/xml/xmlreader.h 98d3473585b5df68991ff4ddcd669808621630cb 
>   akonadi/xml/xmlreader.cpp cdd91f74b9f63f6d2fe19f9e5f00a52a8678c4a3 
> 
> Diff: https://git.reviewboard.kde.org/r/119236/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/