[Kde-pim] Review Request 119462: Per attendee customization of email [4] - individual mail dialog

[Sandro Knauß]

> On Juli 26, 2014, 8:19 vorm., Laurent Montel wrote:
> > incidenceeditor-ng/tests/testindividualmaildialog.cpp, line 12
> > <https://git.reviewboard.kde.org/r/119462/diff/2/?file=292845#file292845line12>
> >
> >     Thanks for unittest.
> >     Perhaps named it "shouldHasDefaultValue()"
> >     
> >     And other function when you change value to see if combobox give you a good value etc.
> >     
> >     To be sure that when you change combobox item we have correct variant
> >     
> >     etc.
> >     We can create a lot of test for testing this dialog box.

If you look into this test:
I tests the default first to make sure the rest of the test has the possibitlity to run successfully. Afterwards I change one entry and test if I have the correct values in editAttendees and updateAttendees. I don't see what to test additionally. This is the only logic that is added by this dialog.

IMO it doesn't make sense to spit the test, because if the defaults ar not like expected all other tests would fail -> they are not independently.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119462/#review63183
-----------------------------------------------------------


On Juli 25, 2014, 9:07 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119462/
> -----------------------------------------------------------
> 
> (Updated Juli 25, 2014, 9:07 nachm.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The last patch of this serie.
> Crating the actual individual mail dialog, to select which attendee should get an update and for whom a composer should be opened.
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/individualmailjobfactory.cpp PRE-CREATION 
>   incidenceeditor-ng/opencomposerjob.h PRE-CREATION 
>   incidenceeditor-ng/opencomposerjob.cpp PRE-CREATION 
>   incidenceeditor-ng/tests/CMakeLists.txt f62466321239da79b1a56449b73ed16afe211a8c 
>   incidenceeditor-ng/tests/testindividualmaildialog.cpp PRE-CREATION 
>   korganizer/calendarview.cpp df3d74139c2363857adecee308b8a0144183f52d 
>   incidenceeditor-ng/individualmaildialog.h PRE-CREATION 
>   incidenceeditor-ng/individualmaildialog.cpp PRE-CREATION 
>   incidenceeditor-ng/individualmailjobfactory.h PRE-CREATION 
>   incidenceeditor-ng/CMakeLists.txt 9097780defc9922424b36cdb7f576a806c8f1fd4 
>   incidenceeditor-ng/Messages.sh b20d68d1e5b615065b5642b1a0bd419b257543a6 
>   incidenceeditor-ng/editoritemmanager.cpp 7cc3614f6343ead48e899c8ff95caaa2a56dd530 
> 
> Diff: https://git.reviewboard.kde.org/r/119462/diff/
> 
> 
> Testing
> -------
> 
> Sending much of invatations around :)
> 
> 
> File Attachments
> ----------------
> 
> The new dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/25/ac439091-58fa-4d8d-a365-810126ff963b__individual-mail.png
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/