[Kde-pim] Review Request 119518: WIP: Add support for tags to the Kolab resource

[Christian Mollekopf]

> On July 28, 2014, 2:12 p.m., Christian Mollekopf wrote:
> > resources/kolab/kolabhelpers.cpp, line 325
> > <https://git.reviewboard.kde.org/r/119518/diff/1/?file=293855#file293855line325>
> >
> >     I'm not sure we actually need to store the kolab objects locally (and therefore sync the collection). We should be able to directly create the tags from the kolab object without storing the (useless) kolab object locally.
> 
> Kevin Krammer wrote:
>     As far as I could tell, the collection is mainly needed to store a UidNextAttribute. At least that is what the similar IMAP tasks do (item add, item remove, item change)

True. We are entering somewhat new territory here since we are syncing that is replicated locally in a different structure (respectively could be invisible in case other configuration objects that are simply written to local configuration). It is therefore entierly possible that the classical approach isn't the most suitable for this case.
It would i.e. be possible to move some of the state information we are currently storing in attributes to configuration files instead (I'm just throwing ideas around).

If creating the collection is the most straightforward way feel free to go that route though.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119518/#review63329
-----------------------------------------------------------


On July 28, 2014, 1:23 p.m., Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119518/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 1:23 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Converts Akonadi::Tag to Kolab::Relation and stores the in a Configuration mailbox/collection.
> 
> 
> Diffs
> -----
> 
>   resources/kolab/CMakeLists.txt 0e8e237a6b9f3d1f77154a0625981ade770a23da 
>   resources/kolab/kolabaddtagtask.h PRE-CREATION 
>   resources/kolab/kolabaddtagtask.cpp PRE-CREATION 
>   resources/kolab/kolabchangeitemstagstask.h PRE-CREATION 
>   resources/kolab/kolabchangeitemstagstask.cpp PRE-CREATION 
>   resources/kolab/kolabchangetagtask.h PRE-CREATION 
>   resources/kolab/kolabchangetagtask.cpp PRE-CREATION 
>   resources/kolab/kolabhelpers.cpp 084bcb537aa7d1eb3a2de4d94413aea04256cf98 
>   resources/kolab/kolabrelationresourcetask.h PRE-CREATION 
>   resources/kolab/kolabrelationresourcetask.cpp PRE-CREATION 
>   resources/kolab/kolabremovetagtask.h PRE-CREATION 
>   resources/kolab/kolabremovetagtask.cpp PRE-CREATION 
>   resources/kolab/kolabresource.h 38889ad9e77467c80353fc61ba808ec107fccd32 
>   resources/kolab/kolabresource.cpp a5e051a56b5579e51e461e876b337b5a7306405b 
> 
> Diff: https://git.reviewboard.kde.org/r/119518/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Krammer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/