[Kde-pim] Review Request 119533: Make ktimetracker build on OS X, where it uses a native method from the ApplicationServices framework for idle time detection, instead of the XScreenSaver.

[RJVB Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119533/
-----------------------------------------------------------

Review request for KDEPIM.


Repository: kdepim


Description
-------

Signed-off-by: RJVB <rjvbertin at gmail.com>


Diffs
-----

  CMakeLists.txt d12b90a3cf294f8a0a236e2021b251b00e85aec3 
  ktimetracker/CMakeLists.txt bf7b0ef41d851055359dc2cdcb2d2d3cbce25a6d 
  ktimetracker/idletimedetector.h 524f739e89a77d1dbd732af8f258b3276e994eba 
  ktimetracker/idletimedetector.cpp 250dda55582f53cfc44242582dee7e07062f5358 
  ktimetracker/ktimetrackerutility.cpp efeba3abdc94a3725f0e0d6a9b663959a06dcc1f 
  ktimetracker/mainwindow.cpp 56d4c286213507490b31fb131f1097a4c00b7abe 

Diff: https://git.reviewboard.kde.org/r/119533/diff/


Testing
-------

Testing was done under KDE and KDEPIM 4.12.5, MacPorts. The patches from that version applied without issues on the code in git, with 2 exceptions that I could re-apply manually easily.

With these patches, ktimetracker builds and launches under OS X (•) and loads existing ktimetracker.ics files correctly. The idle time detection feature appears to work as far as I'm able to tell (I don't use it under Linux).

What remains to be done is to double-check the timing precision: I've had an impression that timing may be too fast but haven't been able to prove timing isn't correct.

The history output to clipboard feature does ignore the date range and "output only the selection" options; removing entries originating from Linux we have

"test"	0.00	0.00
"test->test 1"	0.07	0.03
"test->test 2"	0.00	0.06
"test->test 3"	0.00	0.03
"test->test 4"	0.00	0.03

and the timing output (which does honour the "output only the selection" option):

Totaux des tâches
20140729 13:09

 Durée    Tâche
----------------------------------------------
  0:12    test
   0:05    test 1
   0:03    test 2
   0:02    test 3
   0:02    test 4
----------------------------------------------
  0:12 Total


•) this supposes libical is installed and built following https://trac.macports.org/ticket/44469, i.e. using cmake instead and including a patch from Ubuntu.


Thanks,

RJVB Bertin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/