[Kde-pim] Review Request 119127: Outline for reply and forward

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119127/#review61638
-----------------------------------------------------------



mobile/api/mail/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119127/#comment42883>

    which class or function to you need this for?



mobile/api/mail/composer.h
<https://git.reviewboard.kde.org/r/119127/#comment42884>

    I don't thingyou need these includes here, the forward declarations you added further down should be sufficient



mobile/api/mail/composer.h
<https://git.reviewboard.kde.org/r/119127/#comment42885>

    unnecessary whitespace change?



mobile/api/mail/composer.h
<https://git.reviewboard.kde.org/r/119127/#comment42890>

    Hmm. I don't think these are operations in Composer.
    A composer will be opened as a result of them, no?



mobile/api/mail/composer.h
<https://git.reviewboard.kde.org/r/119127/#comment42886>

    maybe add the empty line before ReceiverModel?
    As a separator between the strings and the object/pointer members?



mobile/api/mail/composer.cpp
<https://git.reviewboard.kde.org/r/119127/#comment42887>

    Don't think you need the name



mobile/api/mail/composer.cpp
<https://git.reviewboard.kde.org/r/119127/#comment42888>

    local variables without m_ prefix. this prefix is used to mark member variables


- Kevin Krammer


On Juli 5, 2014, 10:46 vorm., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119127/
> -----------------------------------------------------------
> 
> (Updated Juli 5, 2014, 10:46 vorm.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Outline for Adding the identity, replyTo, forward to the composer file. It didn't seem to compile until I added kdepim in the cmakelists.txt and messagecomposer/ in the header. I want to know whether this approach is right of using kdepim identity and message factory? For now I am using a test createplaintextmessage(), which has to be replaced by akonadi item. 
> 
> 
> Diffs
> -----
> 
>   messagecore/misc/mdnstateattribute.h c609665 
>   mobile/api/mail/CMakeLists.txt bc1aebe 
>   mobile/api/mail/composer.h b731287 
>   mobile/api/mail/composer.cpp dc750e8 
> 
> Diff: https://git.reviewboard.kde.org/r/119127/diff/
> 
> 
> Testing
> -------
> 
> Yet to be done.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/