[Kde-pim] Review Request 119483: Coding Style for abstractsearchengine.h abstractsearchplugin.h agentsearchengine.h agentsearchinstance.h nepomuksearchengine.h searchmanager.h searchrequest.h searchtaskmanager.h searchtaskmanagerthread.h agentsearchengine.cpp agentsearchinstance.cpp nepomuksearchengine.cpp searchmanager.

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119483/#review63282
-----------------------------------------------------------



server/src/search/nepomuksearchengine.cpp
<https://git.reviewboard.kde.org/r/119483/#comment44101>

    no space after &



server/src/search/nepomuksearchengine.cpp
<https://git.reviewboard.kde.org/r/119483/#comment44102>

    no space after &



server/src/search/nepomuksearchengine.cpp
<https://git.reviewboard.kde.org/r/119483/#comment44103>

    no space after &



server/src/search/searchmanager.cpp
<https://git.reviewboard.kde.org/r/119483/#comment44104>

    no space after &



server/src/search/searchmanager.cpp
<https://git.reviewboard.kde.org/r/119483/#comment44105>

    no space after &



server/src/search/searchmanager.cpp
<https://git.reviewboard.kde.org/r/119483/#comment44106>

    no space after &



server/src/search/searchmanager.cpp
<https://git.reviewboard.kde.org/r/119483/#comment44107>

    no space after &



server/src/search/searchmanager.cpp
<https://git.reviewboard.kde.org/r/119483/#comment44108>

    no space after &



server/src/search/searchmanager.cpp
<https://git.reviewboard.kde.org/r/119483/#comment44109>

    no space after &



server/src/search/searchrequest.cpp
<https://git.reviewboard.kde.org/r/119483/#comment44110>

    no space after *



server/src/search/searchtaskmanager.cpp
<https://git.reviewboard.kde.org/r/119483/#comment44111>

    no space after *



server/src/search/searchtaskmanagerthread.h
<https://git.reviewboard.kde.org/r/119483/#comment44112>

    lets keep this on the same line but move it after the semicolon.
    This is basically a marker, not documentation. in Qt5 we can replace it with Q_DECL_OVERRIDE http://qt-project.org/doc/qt-5/qtglobal.html#Q_DECL_OVERRIDE


- Kevin Krammer


On Juli 26, 2014, 1:09 nachm., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119483/
> -----------------------------------------------------------
> 
> (Updated Juli 26, 2014, 1:09 nachm.)
> 
> 
> Review request for Akonadi and Dan Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   server/src/search/abstractsearchengine.h 9be38b9 
>   server/src/search/abstractsearchplugin.h f51bd5d 
>   server/src/search/agentsearchengine.h 126dd9c 
>   server/src/search/agentsearchengine.cpp d432769 
>   server/src/search/agentsearchinstance.h 78ef5aa 
>   server/src/search/agentsearchinstance.cpp ca6ef87 
>   server/src/search/nepomuksearchengine.h 3110446 
>   server/src/search/nepomuksearchengine.cpp 1cd4dab 
>   server/src/search/searchmanager.h 867c80a 
>   server/src/search/searchmanager.cpp 35e76e1 
>   server/src/search/searchrequest.h 8779e73 
>   server/src/search/searchrequest.cpp 614017e 
>   server/src/search/searchtaskmanager.h 9b7972b 
>   server/src/search/searchtaskmanager.cpp 40eea22 
>   server/src/search/searchtaskmanagerthread.h 37d9cf5 
>   server/src/search/searchtaskmanagerthread.cpp 8cfaa95 
> 
> Diff: https://git.reviewboard.kde.org/r/119483/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/