[Kde-pim] Review Request 115270: Don't add feeds with qdbus when akregator is not loaded in kontact

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115270/#review48154
-----------------------------------------------------------


If you want to check for presence of an object, you should use

QDBusInterface iface("org.kde.akregator", "/Akregator");
return iface.isValid();

/Akregator is a path, so isServiceRegistered() should always return true (since org.kde.akregator is always registered).


- Dan Vrátil


On Jan. 23, 2014, 7:40 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115270/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 7:40 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 244975
>     http://bugs.kde.org/show_bug.cgi?id=244975
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> If akregator_part is not active in kontact we cannot add feeds with
> dbus. Check that /Akregator interface is loaded.
> 
> 
> Diffs
> -----
> 
>   konq-plugins/akregator/pluginbase.cpp 56c0dd4 
> 
> Diff: https://git.reviewboard.kde.org/r/115270/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> I can add feeds when:
>     -akregator is running
>     -akregator is not running
>     -kontact is running with akregator_part loaded
>     -kontact is running without akregator_part loaded
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/