[Kde-pim] Review Request 115182: make it possible to manually select untrusted PGP keys

[Kevin Krammer]

> On Jan. 22, 2014, 2:43 p.m., Sandro Knauß wrote:
> > This patch looks good.
> > For SMIME it doesn't make any difference 'cause ValidTrustedSMIMEEncryptionKey does the same like ValidSMIMEEncryptionKey.

Sandro, since the author is new (as stated in the mail to the list), you'll have to commit this yourself :)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115182/#review48032
-----------------------------------------------------------


On Jan. 21, 2014, 3:14 p.m., kolAflash kolAhilft.de wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115182/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 3:14 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Bugs: 328311
>     http://bugs.kde.org/show_bug.cgi?id=328311
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Fixes a bug in method "selectKeys", when manually selecting one or more
> keys which are not marked as trusted. Method "selectKeys" is only called
> from method "getEncryptionKeys" in lines: 1656, 1696
> 
> "getEncryptionKeys" already checks if the keys are trusted by calling
> "trustedOrConfirmed" and asking the user what to do. But "selectKeys"
> used to remove all untrusted keys from the key-vector before returning,
> so "trustedOrConfirmed" can't ask the user for them.
> 
> Please, somebody else check what I did and if it may has any other
> effects then intended. This is my first upstream KDE patch!!!
> I only checked for the usage of PGP (not S/MIME).
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composer/keyresolver.cpp 17e7342678e15149171e551621be55f213aa2680 
> 
> Diff: https://git.reviewboard.kde.org/r/115182/diff/
> 
> 
> Testing
> -------
> 
> Patched and compiled kdepim 4.11.4 and 4.12.1 on openSUSE 13.1 and build an RPM. In result bug #328311 didn't appeared anymore.
> 
> 
> Thanks,
> 
> kolAflash kolAhilft.de
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/