[Kde-pim] Review Request 114882: calendarviews: make MonthItem respect thisAndFuture flag

[Justus Matthiesen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114882/
-----------------------------------------------------------

(Updated Jan. 12, 2014, 1:20 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and KDEPIM-Libraries.


Repository: kdepim


Description
-------

If a recurrence contains an exception with thisAndFuture set, all subsequent incidences will inherit the exception's data. Thus, recurs() will return false for all subsequent incidences causing IncidenceMonthItem to ignore the offset.

However, since startDate and recurStartDate will be identical in all other cases, it is safe to remove the check.


Diffs
-----

  calendarviews/month/monthitem.cpp 5b2d246812f9ef6e1d7ad0b1983be91c801eba3a 

Diff: https://git.reviewboard.kde.org/r/114882/diff/


Testing
-------

The following calendar file now displays correctly in month view.

BEGIN:VCALENDAR
VERSION:2.0

BEGIN:VEVENT
UID:notveryunique
RECURRENCE-ID;RANGE=THISANDFUTURE:20131204T100000
DTSTART:20131203T110000
DTEND:20131203T120000
SEQUENCE:5
END:VEVENT

BEGIN:VEVENT
UID:notveryunique
RECURRENCE-ID;RANGE=THISANDFUTURE:20131203T100000
DTSTART:20131204T120000
DTEND:20131204T130000
SEQUENCE:4
END:VEVENT

BEGIN:VEVENT
UID:notveryunique
RRULE:FREQ=DAILY;COUNT=7
DTSTART:20131202T100000
DTEND:20131202T110000
END:VEVENT

END:VCALENDAR


Thanks,

Justus Matthiesen

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/