[Kde-pim] Review Request 109291: Adding Qt::ToolTipRole to models where Qt::DisplayRole is used: provides tool tips

[Thomas Fischer]

> On Oct. 10, 2013, 3:48 p.m., Torgny Nyblom wrote:
> > Any news? Should this be marked as abandoned?
> 
> Thomas Fischer wrote:
>     Still waiting for an accept/reject/"change this" answer ...
> 
> Jonathan Marten wrote:
>     Would it be preferable - addressing the question above as to whether tool tips popping up even where they are not actually needed - to only show a tool tip if the item really is truncated?  See http://www.mimec.org/node/337 for a possible solution.
>

Indeed, showing tool tips only when necessary, i.e. when the original text is partially hidden, is the preferred solution. This will require a completely different patch, therefore I'll withdraw this one.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109291/#review41515
-----------------------------------------------------------


On March 5, 2013, 1:17 p.m., Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109291/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 1:17 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The attached patch adds tool tips via Qt::ToolTipRole in many places where a display string is provided via Qt::DisplayRole. This provides a better usability in cases where e.g. columns in lists are too narrow to show the cells' full text.
> 
> 
> Diffs
> -----
> 
>   akonadiconsole/agentconfigmodel.cpp 853e072 
>   akonadiconsole/akonadibrowsermodel.cpp 97e9203 
>   akonadiconsole/jobtrackermodel.cpp d39694a 
>   akonadiconsole/notificationmodel.cpp 6989137 
>   calendarviews/todo/todomodel.cpp 8f36ea6 
>   examples/akonablog/blogmodel.cpp 2c5bde6 
>   examples/coisceim/mixedtreemodel.cpp 46e13c4 
>   examples/etm_usage/mailmodel.cpp 22fc7f4 
>   examples/etm_usage/mixedtreemodel.cpp adb929f 
>   incidenceeditor-ng/freebusyitemmodel.cpp ef2a192 
>   kaddressbook/xxport/csv/qcsvmodel.cpp 84f44e3 
>   kaddressbook/xxport/csv/templateselectiondialog.cpp e2d8aec 
>   kalarm/akonadimodel.cpp c4d8835 
>   kalarm/birthdaymodel.cpp f5191e1 
>   kalarm/eventlistmodel.cpp 3d5bffe 
>   kjots/kjotsmodel.cpp c22fce7 
>   knode/composer/attachment_view.cpp d00300a 
>   libkleo/ui/directoryserviceswidget.cpp 9f1ff2a 
>   mailcommon/filter/filtermodel.cpp d68b0b8 
>   mailcommon/foldertreewidgetproxymodel.cpp c2623a2 
>   messagecomposer/attachmentmodel.cpp ade9292 
>   mobile/contacts/contactcompletionmodel.cpp 5b9a1ee 
>   mobile/contacts/locationmodel.cpp 657aa52 
>   mobile/lib/breadcrumbnavigation.cpp de1a0c0 
>   mobile/mail/templateemailmodel.cpp 2ba07f8 
> 
> Diff: https://git.reviewboard.kde.org/r/109291/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/