[Kde-pim] Review Request 114967: Folder archive was integrated into kmail, therefore integrating the documentation.

[Laurent Montel]

> On Jan. 12, 2014, 7:30 a.m., Laurent Montel wrote:
> > Seems good for me
> > 
> > Ship it.
> >
> 
> Burkhard Lück wrote:
>     @Laurent:
>     configure widget needs a setHelp() call to open the kmail handbook at the correct page now?
>     
>     diff --git a/kmail/folderarchive/folderarchiveconfiguredialog.cpp b/kmail/folderarchive/folderarchiveconfiguredialog.cpp
>     index c174178..27ec1d1 100644
>     --- a/kmail/folderarchive/folderarchiveconfiguredialog.cpp
>     +++ b/kmail/folderarchive/folderarchiveconfiguredialog.cpp
>     @@ -39,7 +39,7 @@ FolderArchiveConfigureDialog::FolderArchiveConfigureDialog(QWidget *parent)
>          setCaption( i18n("Configure") );
>          setWindowIcon( KIcon( QLatin1String("kmail") ) );
>          setButtons( Help|Ok|Cancel );
>     -
>     +    setHelp("archive-folder","kmail");
>          readConfig();
>      
>          mTabWidget = new QTabWidget;
>

Yes it needs it.
Could you add it please ?
Thanks


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114967/#review47243
-----------------------------------------------------------


On Jan. 12, 2014, 4:23 p.m., Scarlett Clark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114967/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2014, 4:23 p.m.)
> 
> 
> Review request for Documentation, KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Moved the documentation from akonadi-folderarchiveagent into the kmail using-kmail backups documention upon request of translators. It is no longer a seperate agent. I will also be git rm the old folder.
> 
> 
> Diffs
> -----
> 
>   doc/kmail/using-kmail.docbook af5b9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/114967/diff/
> 
> 
> Testing
> -------
> 
> checkXML
> 
> 
> Thanks,
> 
> Scarlett Clark
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/