[Kde-pim] Review Request 113909: Revisit the PostgreSQL dbconfig

[Cédric Villemain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113909/
-----------------------------------------------------------

(Updated Jan. 20, 2014, 4:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for Akonadi.


Repository: akonadi


Description
-------

    Remove defaultCleanShutdownCommand setting, this used to contain a mix of
    command and parameters. I kept only the PGDATA in mPgData (new setting).
    
    Use the socketDir defined by mHostName (Host setting), set by init() when using
    an internal server, instead of building the path each time its required.
    
    Cosmetic: expand command arguments to longer ones when possible
              "-D" -> "--pgdata"
              Change star to 1 in database query check
              "SELECT *" --> "SELECT 1"
    
    Remove PostgreSQL configuration file management, we use the command arguments
    only.
    
    Improve PostgreSQL internal shutdown sequence by issueing FAST then IMMEDIATE
    the KILL ABRT. (IMMEDIATE wasn't used previously)


Diffs
-----

  server/src/storage/dbconfigpostgresql.h c4c5f19ef8e3f57018e8a7e921a726dc9e5b17dc 
  server/src/storage/dbconfigpostgresql.cpp 3ca098bff11e3e9824c7b555fe96039329c1fbcf 

Diff: https://git.reviewboard.kde.org/r/113909/diff/


Testing
-------

no(t yet) :-) (well, it builds)

Is there a 'make test' or similar I can use for that ?


Thanks,

Cédric  Villemain

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/