[Kde-pim] Review Request 114941: Coding Style for contacteditorwidget.cpp

[Guy Maurel]

> On Jan. 10, 2014, 5:55 p.m., Kevin Krammer wrote:
> > akonadi/contact/editor/contacteditorwidget.cpp, line 138
> > <https://git.reviewboard.kde.org/r/114941/diff/1/?file=233677#file233677line138>
> >
> >     I am not so sure here.
> >     Usually we place the * at the variable or argument name, but does it make sense here in a template where there is never a name?

Yes.
Let say: We put a space between the type and the star.


> On Jan. 10, 2014, 5:55 p.m., Kevin Krammer wrote:
> > akonadi/contact/editor/contacteditorwidget.cpp, line 573
> > <https://git.reviewboard.kde.org/r/114941/diff/1/?file=233677#file233677line573>
> >
> >     maybe we can add a name for the argument here?
> >     Most likely "parent"
> >     we could even consider forwarding that to the base class constructor then.
> >     hmm, maybe as a separate change?
> >

mmhh!
My test should have found it.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114941/#review47149
-----------------------------------------------------------


On Jan. 11, 2014, 5:28 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114941/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2014, 5:28 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> # Using:
> astyle \
>     --indent=spaces --max-instatement-indent=80 --indent-cases \
>     --pad-header --pad-oper --unpad-paren \
>     --align-pointer=name --align-reference=name \
>     --max-instatement-indent=80 --min-conditional-indent=1 \
>     $1
> #
> # correct the SIGNAL and SLOT macros:
> normalize --modify $1
> #
> # change " & " to " &"
> gawk -f ${DIR}/Change-spaceANDspace.awk $1 > $1-a
> mv $1-a $1
> #
> # change "[ " to "[" and " ]" to "]"
> gawk -f ${DIR}/spaceInArray-change.awk ${WHERE} > ${WHERE}-k
> mv ${WHERE}-k ${WHERE}
> #
> # delete one line if two empties lines are present 
> gawk -f ${DIR}/Twice-change.awk $1 > $1-a
> mv $1-a $1
> #
> # delete first/last empty line(s)
> gawk -f ${DIR}/First-change.awk ${WHERE} > ${WHERE}-c
> mv ${WHERE}-c ${WHERE}
> #
> # lines with initialization(s)
> gawk -f ${DIR}/Default-1-change.awk < ${WHERE} > ${WHERE}-d1
> mv ${WHERE}-d1 ${WHERE}
> gawk -f ${DIR}/Default-2-change.awk < ${WHERE} > ${WHERE}-d2
> mv ${WHERE}-d2 ${WHERE}
> #
> # change <SPACE> after keyword
> ${DIR}/coding-style-change-SpaceAfter.sh ${WHERE}
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/editor/contacteditorwidget.cpp 6db9be0 
> 
> Diff: https://git.reviewboard.kde.org/r/114941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/