[Kde-pim] Review Request 115182: make it possible to manually select untrusted PGP keys

[kolAflash kolAhilft.de]

> On Jan. 22, 2014, 3:43 p.m., Sandro Knauß wrote:
> > This patch looks good.
> > For SMIME it doesn't make any difference 'cause ValidTrustedSMIMEEncryptionKey does the same like ValidSMIMEEncryptionKey.
> 
> Kevin Krammer wrote:
>     Sandro, since the author is new (as stated in the mail to the list), you'll have to commit this yourself :)
> 
> kolAflash kolAhilft.de wrote:
>     I think I don't have the right to commit something to git.
>     
>     Concerning "ValidTrustedSMIMEEncryptionKey" and "ValidSMIMEEncryptionKey":
>     Hmm... maybe they shouldn't be the same and there's another bug.
>     I don't use S/MIME frequently, but I remember that once when I used S/MIME certificates signed by http://cacert.org (which isn't marked as trustworthy in my Kleopatra) for sender an receiver KMail asked me, because the certificate isn't trusted. I answered "Continue" but nevertheless KMail denied to encrypt and/or sign the message because of "Not trustworthy".
>     The only way to override was to mark the whole CaCert-Authority as trustworthy in Kleopatra.
>     => Just tested again, using S/MIME and it's still that way!
>     
>     But as I said, I like to use PGP/Mime much more :-)

Did a little debugging with Kdbg. Doesn't looks like "ValidTrustedSMIMEEncryptionKey" and "ValidSMIMEEncryptionKey" are called at all in the behavior I described.

So if you have no concerns, it would be nice if you commit my patch.


- kolAflash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115182/#review48032
-----------------------------------------------------------


On Jan. 21, 2014, 4:14 p.m., kolAflash kolAhilft.de wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115182/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 4:14 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Bugs: 328311
>     http://bugs.kde.org/show_bug.cgi?id=328311
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Fixes a bug in method "selectKeys", when manually selecting one or more
> keys which are not marked as trusted. Method "selectKeys" is only called
> from method "getEncryptionKeys" in lines: 1656, 1696
> 
> "getEncryptionKeys" already checks if the keys are trusted by calling
> "trustedOrConfirmed" and asking the user what to do. But "selectKeys"
> used to remove all untrusted keys from the key-vector before returning,
> so "trustedOrConfirmed" can't ask the user for them.
> 
> Please, somebody else check what I did and if it may has any other
> effects then intended. This is my first upstream KDE patch!!!
> I only checked for the usage of PGP (not S/MIME).
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composer/keyresolver.cpp 17e7342678e15149171e551621be55f213aa2680 
> 
> Diff: https://git.reviewboard.kde.org/r/115182/diff/
> 
> 
> Testing
> -------
> 
> Patched and compiled kdepim 4.11.4 and 4.12.1 on openSUSE 13.1 and build an RPM. In result bug #328311 didn't appeared anymore.
> 
> 
> Thanks,
> 
> kolAflash kolAhilft.de
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/