[Kde-pim] Review Request 114341: Fix a bug in kmail that eats all cpu

[Raul Fernandes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114341/
-----------------------------------------------------------

(Updated Jan. 10, 2014, 4:32 p.m.)


Review request for KDEPIM.


Changes
-------

Remove the connect from Kernel::findCreateDefaultCollection() function, add it to Kernel::initFolders() and create Kernel::checkFolders() function that is called by Kernel::slotDefaultCollectionsChanged().
Patch to KDE 4.12 branch.


Bugs: 323929
    http://bugs.kde.org/show_bug.cgi?id=323929


Repository: kdepim


Description
-------

The bug is described in https://bugs.kde.org/show_bug.cgi?id=323929.
The bug triggers several queries to akonadi to get the same information.
I think it is caused by the repeated connect() calls in initFolders() function (even using the Qt::UniqueConnection).
So everytime the function slotDefaultCollectionsChanged() is called, disconnect the signal to avoid accumulate multiple signals.
I think the right way is to rewrite the initFolders to call connect() only once.
Split initFolders() in 2 functions. One is called by kmail and another (with the connect()) called by slotDefaultCollectionsChanged().
For now, the disconnect() should be a good workaround for the (critical) bug.


Diffs (updated)
-----

  mailcommon/kernel/mailkernel.h 7cce1f8 
  mailcommon/kernel/mailkernel.cpp 4198994 

Diff: https://git.reviewboard.kde.org/r/114341/diff/


Testing
-------

Until now, it is ok here.


File Attachments
----------------

kmail.log.lrz
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/07/1fe839f7-aea6-462a-8310-57be1afbb14f__kmail.log.lrz
Recompressed log file
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/08/2502547f-e827-40ae-9fe5-dd1bcaad3168__log.tar.xz
Log sorted by occurrences
  https://git.reviewboard.kde.org/media/uploaded/files/2013/12/08/68881267-6582-4dbb-a02b-0ffcc49f0e3c__kmail-sorted.log.gz


Thanks,

Raul Fernandes

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/