[Kde-pim] Review Request 113907: Nicer job names in KIMAP

Sun Jan 12 15:03:00 GMT 2014

> On Nov. 26, 2013, 7:23 a.m., Christian Mollekopf wrote:
> > I really don't understand why we need translatable strings for the names of an IMAP Job in the first place. If those strings appear in anything meaningful to the user, we should simply remove them as an implementation detail, but translating IMAP commands? Sounds to me as useful as translating "akonadi".
> > That said, and since the strings are already translated, feel free to ship it if it helps as workaround for now. Otherwise get in touch with me so we can look into removing the offending messages.
> 
> Alexander Potashev wrote:
>     These strings ("AclJobBase", "DeleteAclJob", ...) are indeed already translated. But since this patch changes the original strings (e.g. "DeleteAclJob" to "Deleting rights from ACL"), this requires some effort from translators.
>     
>     Anyway, why this hasn't been merged yet?
> 
> Lasse Liehu wrote:
>     I think the idea was to make a new version that fixes the problem of bad error messages better. For example so that IMAP jobs would have their own error messages that avoid showing the IMAP command name. Currently almost all jobs have the same error message "%1 failed, server replied: %2", where %1 is name of the job and %2 is response from server. Of course it would probably be even better if users of kimap showed their own error messages that made sense in context.
> 
> Alexander Potashev wrote:
>     I think it's something that should be discussed inside kde-i18n-doc, not kde-pim. As a KDE translator, I'm fine with what your patch suggests as well as what these messages currently look like, since I can translate "DeleteAclJob"/etc in a user-friendly way as much as possible. If your plan is to make these error messages even more detailed, then it would be too much effort from you and from translators, IMO.
> 
> Lasse Liehu wrote:
>     This was discussed in kde-i18n-doc, but then I didn't get around to make a new version of the error messages and ask for opinion on those. See http://lists.kde.org/?l=kde-i18n-doc&m=138556183418901&w=2
>     
>     Anyway, I can ship this as is. I'm also a KDE translator and have already translated these messages so that they look like what is in this patch.
> 
> Alexander Potashev wrote:
>     Oh, sorry. May be we should indeed leave technical strings like "DeleteAclJob" without translation so the user gets "Request '<some-request>' failed, error message is '<some-message>'" where <some-request> is not translated?
>     
>     If you get a BSOD on MS Windows, you get some error code like IRQL_NOT_LESS_OR_EQUAL without any description. And the user does not really need any description for it. If he is really into Windows kernel, then he can lookup what IRQL_NOT_LESS_OR_EQUAL actually means.

Yes, the plan remains that I eventually make the job names non-translatable (probably for frameworks) and remove them from any user visible strings. As discussed, the user-facing non-technical error message should be added in the imap resource, and the technical description in .xsession-errors should be in english. That way the translators have less work and the developers get sane error messages. So this review request should be discarded. I didn't get to fix the error messages in the imap resource, but it's on my list.

Thanks

- Christian

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113907/#review44474
-----------------------------------------------------------

On Nov. 27, 2013, 1:40 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113907/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2013, 1:40 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Following up on http://lists.kde.org/?l=kde-pim&m=137398746102545&w=2
> 
> If a job corresponded to an IMAP command that I wasn’t able to describe in a user-friendlier way, I changed the job name to “IDLE command” and similar because I thought that is probably easier to understand and translate than “Idle failed”. Better ideas welcome.
> 
> 
> Diffs
> -----
> 
>   kimap/selectjob.cpp 71732f9 
>   kimap/setacljob.cpp c1144de 
>   kimap/setmetadatajob.cpp 2938d1f 
>   kimap/setquotajob.cpp 6b05b3c 
>   kimap/storejob.cpp c0f222d 
>   kimap/subscribejob.cpp 89f1e76 
>   kimap/unsubscribejob.cpp 4331f79 
>   kimap/myrightsjob.cpp fa6e0f1 
>   kimap/namespacejob.cpp 4176f8b 
>   kimap/quotajobbase.cpp 7a48b44 
>   kimap/renamejob.cpp 80b396e 
>   kimap/searchjob.cpp 5842c4c 
>   kimap/copyjob.cpp 97e7109 
>   kimap/createjob.cpp 4a45479 
>   kimap/deleteacljob.cpp 658caae 
>   kimap/deletejob.cpp 6709d94 
>   kimap/expungejob.cpp 483ca38 
>   kimap/fetchjob.cpp fa49fbd 
>   kimap/getacljob.cpp 054e989 
>   kimap/getmetadatajob.cpp 8c13fbb 
>   kimap/getquotajob.cpp 005b930 
>   kimap/getquotarootjob.cpp 71f3a95c 
>   kimap/idlejob.cpp 0075473 
>   kimap/job.cpp 4a6d41f 
>   kimap/job_p.h 6e4b717 
>   kimap/listjob.cpp 755187b 
>   kimap/listrightsjob.cpp aa478e1 
>   kimap/loginjob.cpp 768794f 
>   kimap/logoutjob.cpp de552b6 
>   kimap/metadatajobbase.cpp 2b32cb3 
>   kimap/acljobbase.cpp 7a3660e 
>   kimap/appendjob.cpp 5035214 
>   kimap/capabilitiesjob.cpp f2d2605 
>   kimap/closejob.cpp d84d247 
> 
> Diff: https://git.reviewboard.kde.org/r/113907/diff/
> 
> 
> Testing
> -------
> 
> Compilation
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/