[Kde-pim] Review Request 114839: Coding Style for smsdialog.h

[Guy Maurel]

Hello !

I made an error yesterday by sending 16 requests at new.
Sorry, I was on the wrong directory!

guy
======
On Friday, January 03, 2014 08:46:20 PM Kevin Krammer wrote:
> On Friday, 2014-01-03, 14:11:52, Gene Heskett wrote:
> > On Friday 03 January 2014 14:08:59 Kevin Krammer did opine:
> > > On Friday, 2014-01-03, 13:37:53, Gene Heskett wrote:
> > > > I just got 16 of these.  Like Lawrence Welks bubble machine.
> > > > Intended?
> > > > 
> > > > Or do I have a fetchmail vs server problem?
> > > 
> > > If you got 16 identical ones yes :)
> > > 
> > > I got several different ones.
> > > 
> > > Cheers,
> > > Kevin
> > 
> > Different in that the each referred to a different file in the subject
> > line
> > but then used identical gawk or similar language to do the edit of each
> > file.
> 
> Ah, I see.
> 
> > One email, with all the diff's merged would have been a lot less noise.
> 
> True, but it is a trade-off between number of mails and amount of changes
> per review request.
> 
> Smaller reviews partition the work.
> Muliple people can work on different reviews.
> The over all time required can be paritioned into smaller chunks which are
> usually easier to allocate then a single large chunk.
> The required concentration doesn't have to be held for a long time, only for
> a couple minutes each.
> Any issue only blocks a small request, the next review iteration only needs
> to review this small, self contained, subset.
> Smaller change sets make conflicts less likely and can more easily be
> resolved.
> 
> From my point of view these advantages far outweight the disadvantages.
> In fact I personally requested this way of doing it, since I am the one
> doing most of the reviews.
> 
> Cheers,
> Kevin

-- 
Guy Maurel
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/