[Kde-pim] Review Request 115318: Fix strigi analyzers not compiling even though strigi is found

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115318/#review48363
-----------------------------------------------------------


strigi-analyzers were removed in master (2bfffcbc), because they were not used by Nepomuk anymore and won't be needed for Baloo.

I don't know whether there's much point in enabling them for 4.12, since they are not used by anyone. Do they even compile?

- Dan Vrátil


On Jan. 26, 2014, 7:31 a.m., Matthew John Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115318/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2014, 7:31 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> During Plasma Active work, I discovered the strigi analyzers were no longer compiling or installing.  At some point, the variable for whether strigi is found or not changed its name to be all uppercase.  Fix the top level CMakeLists.txt to account for this difference.
> 
> I have no idea when this change occurred, or why it wasn't noticed earlier.  Under master, strigi is no longer even searched for.  Would it be preferred to just delete the analyzers on the master branch?
> 
> This patch is originally from KDE/4.11, forwarded ported to KDE/4.12.  I'd like to commit to 4.11, 4.12, and master.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b445e3a 
> 
> Diff: https://git.reviewboard.kde.org/r/115318/diff/
> 
> 
> Testing
> -------
> 
> Just a straight compile was tested on the KDE/4.11 branch, were the plasma active work was being done.
> 
> 
> Thanks,
> 
> Matthew John Dawson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/