[Kde-pim] Review Request 114861: Coding Style for immodel.cpp

[Kevin Krammer]

> On Jan. 4, 2014, 5:43 p.m., Kevin Krammer wrote:
> > akonadi/contact/editor/im/immodel.cpp, line 97
> > <https://git.reviewboard.kde.org/r/114861/diff/1/?file=230059#file230059line97>
> >
> >     maybe name argument "index" and add Q_UNUSED for it=

I just saw that it is called "child" in the header, so used that instead of "index"?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114861/#review46805
-----------------------------------------------------------


On Jan. 4, 2014, 5:16 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114861/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2014, 5:16 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Kevin Krammer and Jonathan Marten.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> # Using:
> astyle \
>     --indent=spaces --max-instatement-indent=80 --indent-cases \
>     --pad-header --pad-oper --unpad-paren \
>     --align-pointer=name --align-reference=name \
>     --max-instatement-indent=80 \
>     $1
> #
> # correct the SIGNAL and SLOT macros:
> normalize --modify $1
> #
> # change " & " to " &"
> gawk -f ${DIR}/Change-spaceANDspace.awk $1 > $1-a
> mv $1-a $1
> #
> # delete one line if two empties lines are present 
> gawk -f ${DIR}/Twice-change.awk $1 > $1-a
> mv $1-a $1
> #
> # delete first/last empty line(s)
> gawk -f ${DIR}/First-change.awk ${WHERE} > ${WHERE}-c
> mv ${WHERE}-c ${WHERE}
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/editor/im/immodel.cpp 7b6d2c0 
> 
> Diff: https://git.reviewboard.kde.org/r/114861/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/