[Kde-pim] Review Request 113909: Revisit the PostgreSQL dbconfig

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113909/#review47305
-----------------------------------------------------------


Looks fine, you just need to fix the switches. Apparently for long-name switches you have to use "=" instead of space. With this fixed, I can start Akonadi with PostgreSQL just fine.


server/src/storage/dbconfigpostgresql.cpp
<https://git.reviewboard.kde.org/r/113909/#comment33697>

    --pgdata=/home/....



server/src/storage/dbconfigpostgresql.cpp
<https://git.reviewboard.kde.org/r/113909/#comment33696>

    --pgdata=%2



server/src/storage/dbconfigpostgresql.cpp
<https://git.reviewboard.kde.org/r/113909/#comment33694>

    --timeout=10



server/src/storage/dbconfigpostgresql.cpp
<https://git.reviewboard.kde.org/r/113909/#comment33691>

    --pgdata=%1



server/src/storage/dbconfigpostgresql.cpp
<https://git.reviewboard.kde.org/r/113909/#comment33692>

    pg_ctl does not have a -k switch, so it has to be passed to postgres command via -o switch
    
    -o \"-k %1\"
    
    



server/src/storage/dbconfigpostgresql.cpp
<https://git.reviewboard.kde.org/r/113909/#comment33693>

    pg_ctl does not have -h switch, but passing it to postgres via -o switch does not work either - the server refuses to start.
    
    Since postgres has an "-i" switch to explicitely enable TCP/IP connections, I wonder whether this is needed at all



server/src/storage/dbconfigpostgresql.cpp
<https://git.reviewboard.kde.org/r/113909/#comment33698>

    --pgdata=%1



server/src/storage/dbconfigpostgresql.cpp
<https://git.reviewboard.kde.org/r/113909/#comment33699>

    --mode=fast



server/src/storage/dbconfigpostgresql.cpp
<https://git.reviewboard.kde.org/r/113909/#comment33700>

    --pgdata=%1



server/src/storage/dbconfigpostgresql.cpp
<https://git.reviewboard.kde.org/r/113909/#comment33701>

    --mode=immediate


- Dan Vrátil


On Nov. 17, 2013, 6:55 p.m., Cédric  Villemain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113909/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2013, 6:55 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
>     Remove defaultCleanShutdownCommand setting, this used to contain a mix of
>     command and parameters. I kept only the PGDATA in mPgData (new setting).
>     
>     Use the socketDir defined by mHostName (Host setting), set by init() when using
>     an internal server, instead of building the path each time its required.
>     
>     Cosmetic: expand command arguments to longer ones when possible
>               "-D" -> "--pgdata"
>               Change star to 1 in database query check
>               "SELECT *" --> "SELECT 1"
>     
>     Remove PostgreSQL configuration file management, we use the command arguments
>     only.
>     
>     Improve PostgreSQL internal shutdown sequence by issueing FAST then IMMEDIATE
>     the KILL ABRT. (IMMEDIATE wasn't used previously)
> 
> 
> Diffs
> -----
> 
>   server/src/storage/dbconfigpostgresql.h c4c5f19ef8e3f57018e8a7e921a726dc9e5b17dc 
>   server/src/storage/dbconfigpostgresql.cpp 3ca098bff11e3e9824c7b555fe96039329c1fbcf 
> 
> Diff: https://git.reviewboard.kde.org/r/113909/diff/
> 
> 
> Testing
> -------
> 
> no(t yet) :-) (well, it builds)
> 
> Is there a 'make test' or similar I can use for that ?
> 
> 
> Thanks,
> 
> Cédric  Villemain
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/