[Kde-pim] Review Request 115270: Don't add feeds with qdbus when akregator is not loaded in kontact

[Kevin Krammer]

> On Jan. 23, 2014, 7:19 p.m., Kevin Krammer wrote:
> > I don't quite understand: Akregator is instantiated and has registered its connection with the session bus but has not registered its main object?
> 
> Maarten De Meyer wrote:
>     Looking at akregator_part.cpp the /Akregator object is registerd there.
>     But if I start kontact without selecting the feed plugin it's not registered with dbus.
>     
>      $ qdbus org.kde.akregator
>     /
>     /KIO
>     /KIO/Scheduler
>     /KontactInterface
>     /MainApplication
>     /akregator_PimApplication
>     /kaddressbook_PimApplication
>     /kjots_PimApplication
>     /knotes_PimApplication
>     /kontact
>     /kontact/MainWindow_1
>     /kontact/MainWindow_1/actions
>     /kontact/MainWindow_1/actions/file_quit
>     /kontact/MainWindow_1/actions/options_configure_keybinding
>     /kontact/MainWindow_1/actions/options_configure_toolbars
>     /korganizer_PimApplication
> 
> Kevin Krammer wrote:
>     I see. Hmm, I wonder if the correct fix is not to make sure that the object is registered if the name is instead of instead of working around in clients to cope with a "half-started" service
> 
> Maarten De Meyer wrote:
>     Alright, makes sense.
>     I'll add a todo for now and close this request.
>     
>     Thanks.

Thank you for looking into this in the first place


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115270/#review48156
-----------------------------------------------------------


On Jan. 23, 2014, 6:53 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115270/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 6:53 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 244975
>     http://bugs.kde.org/show_bug.cgi?id=244975
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> If akregator_part is not active in kontact we cannot add feeds with
> dbus. Check that /Akregator interface is loaded.
> 
> 
> Diffs
> -----
> 
>   konq-plugins/akregator/pluginbase.cpp 56c0dd4 
> 
> Diff: https://git.reviewboard.kde.org/r/115270/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> I can add feeds when:
>     -akregator is running
>     -akregator is not running
>     -kontact is running with akregator_part loaded
>     -kontact is running without akregator_part loaded
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/