[Kde-pim] Review Request 114949: Coding Style for customfieldsmodel.cpp

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114949/#review48797
-----------------------------------------------------------



akonadi/contact/editor/customfieldsmodel.cpp
<https://git.reviewboard.kde.org/r/114949/#comment34453>

    that looks wrong, maybe the script sees the : like the : in a class initializer list.
    the two value of the condition assignment should either be on the same line (as before) or aligned with each other.
    
    IMHO these are the ways to format the confitional assignment:
    
    a == b ? c : d
    
    a == b
        ? c
        : d
    
    a == b ?
        c : d
    
    a == b
        ? c : d


- Kevin Krammer


On Feb. 2, 2014, 6:08 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114949/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2014, 6:08 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> # Using:
> astyle \
>     --indent=spaces --max-instatement-indent=80 --indent-cases \
>     --pad-header --pad-oper --unpad-paren \
>     --align-pointer=name --align-reference=name \
>     --max-instatement-indent=80 --min-conditional-indent=1 \
>     $1
> #
> # correct the SIGNAL and SLOT macros:
> normalize --modify $1
> #
> # change " & " to " &"
> gawk -f ${DIR}/Change-spaceANDspace.awk $1 > $1-a
> mv $1-a $1
> #
> # change "[ " to "[" and " ]" to "]"
> gawk -f ${DIR}/spaceInArray-change.awk ${WHERE} > ${WHERE}-k
> mv ${WHERE}-k ${WHERE}
> #
> # delete one line if two empties lines are present 
> gawk -f ${DIR}/Twice-change.awk $1 > $1-a
> mv $1-a $1
> #
> # delete first/last empty line(s)
> gawk -f ${DIR}/First-change.awk ${WHERE} > ${WHERE}-c
> mv ${WHERE}-c ${WHERE}
> #
> # lines with initialization(s)
> gawk -f ${DIR}/Default-1-change.awk < ${WHERE} > ${WHERE}-d1
> mv ${WHERE}-d1 ${WHERE}
> gawk -f ${DIR}/Default-2-change.awk < ${WHERE} > ${WHERE}-d2
> mv ${WHERE}-d2 ${WHERE}
> #
> # change <SPACE> after keyword
> ${DIR}/coding-style-change-SpaceAfter.sh ${WHERE}
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/editor/customfieldsmodel.cpp dc26a6d 
> 
> Diff: https://git.reviewboard.kde.org/r/114949/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/