[Kde-pim] Review Request 116409: Coding Style for standardactionmanager.cpp

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116409/#review51257
-----------------------------------------------------------


On many places, there are {} missing around single line if() statement, i.e.

if (...)
   doSomething();

About half way through the review I realized this is missing on too many places, so I didn't put a note to all places where {} is missing at if() statements. All for() and foreach() statements where {] are missing should be highlighted.


akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36030>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36031>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36032>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36033>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36034>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36035>

    Insert an empty line between the line above and this line



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36036>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36037>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36038>

    Missing {]



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36039>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36040>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36041>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36042>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36043>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36044>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36045>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36046>

    Wrong indentation



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36047>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36048>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36049>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36050>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36051>

    { on a new line



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36052>

    Wrong indentation



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36053>

    Add empty line above this line



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36054>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36055>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36056>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36057>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36058>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36059>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36060>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36061>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36063>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36062>

    Wrong indentation



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36064>

    Missing {}



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36065>

    Wrong indentation



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36066>

    Wrong indentation



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36067>

    Wrong indentation



akonadi/standardactionmanager.cpp
<https://git.reviewboard.kde.org/r/116409/#comment36068>

    Missing {}


- Dan Vrátil


On Feb. 27, 2014, 6:52 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116409/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 6:52 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/standardactionmanager.cpp 52f57fe 
> 
> Diff: https://git.reviewboard.kde.org/r/116409/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/