[Kde-pim] Review Request 115846: kontact summary view

[Kevin Krammer]

> On Feb. 18, 2014, 4:49 p.m., Kevin Krammer wrote:
> > kontact/plugins/korganizer/kcmapptsummary.cpp, line 42
> > <https://git.reviewboard.kde.org/r/115846/diff/1/?file=244666#file244666line42>
> >
> >     is this an unrelated change that crept into this diff?
> 
> Eugenio Accorsi wrote:
>     i deleted that because they are not used, these variables are defined in the ui file.

there might be objects with similar names, but at least mDaysButtonGroup might still be needed.
It governs the exclusivness between three radiobuttons. Radio buttons do that themselves if they have the same parent, but they do not have the same parent, one of them has a different one.

I would prefer of you kept this exclusivness handling the way it is, just to be safe.

The other two might have been used to make connecting easier, i.e. connect to only one signal source instead of many. but at least they are not used for exclusinvess handling


> On Feb. 18, 2014, 4:49 p.m., Kevin Krammer wrote:
> > kontact/plugins/specialdates/sdsummarywidget.cpp, line 368
> > <https://git.reviewboard.kde.org/r/115846/diff/1/?file=244670#file244670line368>
> >
> >     does the comment no longer apply?
> 
> Eugenio Accorsi wrote:
>     i think this check is to prevent the following case: one event from the KABC-BIRTHADY/ANNIVERSARY and one from the contact. but since i check it above i think that it's not needed anymore

Ok. Needs verification by one of the calendar people :)


> On Feb. 18, 2014, 4:49 p.m., Kevin Krammer wrote:
> > kontact/plugins/specialdates/sdsummarywidget.cpp, line 667
> > <https://git.reviewboard.kde.org/r/115846/diff/1/?file=244670#file244670line667>
> >
> >     Hmm. That will go through all contacts. I think the special job was to prevent that, i.e. do not require tons of contacts to be loaded that then do not contains birthday information
> 
> Eugenio Accorsi wrote:
>     i changed it to fecth all contact now using a different approach and it's faster (but i have only ~100 contacts and so cannot test with more).
>     the problem with the previous job is that i does not work every time for me (and also it is deprecated now).

I guess ideally the old job would be extended to also query for contacts with anniversaries.
The "problem" is that the used search provider is about to change in the next release and it uses a different query syntax. Lets see if we can get some help on this.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115846/#review50163
-----------------------------------------------------------


On Feb. 19, 2014, 10:43 a.m., Eugenio Accorsi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115846/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 10:43 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 278956
>     http://bugs.kde.org/show_bug.cgi?id=278956
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> since i use kontact very often i tried to make the summary view work as expected.
> the only problem with this patch is the special event plugin.
> maybe someone with better experience with akonadi can steer me in the right direction..
> i changed the old implementation because it doesn't work for every contact.
> 
> 
> Diffs
> -----
> 
>   kontact/plugins/korganizer/apptsummaryconfig_base.ui 93e72bd 
>   kontact/plugins/korganizer/apptsummarywidget.h 95bfe3b 
>   kontact/plugins/korganizer/apptsummarywidget.cpp 33fff04 
>   kontact/plugins/korganizer/kcmapptsummary.h bddab14 
>   kontact/plugins/korganizer/kcmapptsummary.cpp 6a661a4 
>   kontact/plugins/korganizer/summaryeventinfo.h a9bb775 
>   kontact/plugins/korganizer/summaryeventinfo.cpp 00c9906 
>   kontact/plugins/specialdates/kcmsdsummary.h 778c389 
>   kontact/plugins/specialdates/kcmsdsummary.cpp 3b9c5a4 
>   kontact/plugins/specialdates/sdsummarywidget.h 9076c79 
>   kontact/plugins/specialdates/sdsummarywidget.cpp 67990c3 
> 
> Diff: https://git.reviewboard.kde.org/r/115846/diff/
> 
> 
> Testing
> -------
> 
> in the special-occasion plugin enabling the search for special events in contacts will result in high cpu usage by nepomuk.
> i tried also with master but it does not find any contacts.
> the summary event plugin works as expected.
> 
> 
> Thanks,
> 
> Eugenio Accorsi
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/