[Kde-pim] Review Request 116413: Coding Style for subscriptiondialog.cpp

Dan Vrátil dvratil at redhat.com
Fri Feb 28 00:04:20 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116413/#review51252
-----------------------------------------------------------



akonadi/subscriptiondialog.cpp
<https://git.reviewboard.kde.org/r/116413/#comment36010>

    {} on a new line



akonadi/subscriptiondialog.cpp
<https://git.reviewboard.kde.org/r/116413/#comment36011>

    Remove whitespace



akonadi/subscriptiondialog.cpp
<https://git.reviewboard.kde.org/r/116413/#comment36012>

    Wrong indentation of this whole block



akonadi/subscriptiondialog.cpp
<https://git.reviewboard.kde.org/r/116413/#comment36013>

    {} on new line



akonadi/subscriptiondialog.cpp
<https://git.reviewboard.kde.org/r/116413/#comment36014>

    Remove whitespace



akonadi/subscriptiondialog.cpp
<https://git.reviewboard.kde.org/r/116413/#comment36015>

    Wrong identation



akonadi/subscriptiondialog.cpp
<https://git.reviewboard.kde.org/r/116413/#comment36016>

    Missing {}


- Dan Vrátil


On Feb. 27, 2014, 6:52 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116413/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 6:52 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/subscriptiondialog.cpp a4b0c07 
> 
> Diff: https://git.reviewboard.kde.org/r/116413/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list