[Kde-pim] Review Request 116411: Coding Style for statisticsproxymodel.cpp

Dan Vrátil dvratil at redhat.com
Fri Feb 28 00:08:13 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116411/#review51254
-----------------------------------------------------------



akonadi/statisticsproxymodel.cpp
<https://git.reviewboard.kde.org/r/116411/#comment36017>

    Should be on the same line as "if"



akonadi/statisticsproxymodel.cpp
<https://git.reviewboard.kde.org/r/116411/#comment36019>

    Should be on the same line as } above and { below



akonadi/statisticsproxymodel.cpp
<https://git.reviewboard.kde.org/r/116411/#comment36020>

    Move to the line above



akonadi/statisticsproxymodel.cpp
<https://git.reviewboard.kde.org/r/116411/#comment36021>

    Move to the while() line above



akonadi/statisticsproxymodel.cpp
<https://git.reviewboard.kde.org/r/116411/#comment36022>

    Missing {}



akonadi/statisticsproxymodel.cpp
<https://git.reviewboard.kde.org/r/116411/#comment36023>

    Missing {}



akonadi/statisticsproxymodel.cpp
<https://git.reviewboard.kde.org/r/116411/#comment36024>

    Missing {}



akonadi/statisticsproxymodel.cpp
<https://git.reviewboard.kde.org/r/116411/#comment36025>

    Missing {}



akonadi/statisticsproxymodel.cpp
<https://git.reviewboard.kde.org/r/116411/#comment36026>

    Don't remove the space between & and (



akonadi/statisticsproxymodel.cpp
<https://git.reviewboard.kde.org/r/116411/#comment36027>

    Missing {}



akonadi/statisticsproxymodel.cpp
<https://git.reviewboard.kde.org/r/116411/#comment36028>

    Missing {}


- Dan Vrátil


On Feb. 27, 2014, 6:52 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116411/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 6:52 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/statisticsproxymodel.cpp eb9404b 
> 
> Diff: https://git.reviewboard.kde.org/r/116411/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list