[Kde-pim] Review Request 115817: when connection to server fails, set it offline and retry later
Dan Vrátil
dvratil at redhat.com
Mon Feb 17 15:51:38 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115817/#review50057
-----------------------------------------------------------
resources/dav/resource/davgroupwareresource.cpp
<https://git.reviewboard.kde.org/r/115817/#comment35162>
Is there a specific error code for host unreachable? I think we should not show a warning to users if we are going to upload the change later. In other cases (server error) this is OK of course.
Applies for other warning()s too
- Dan Vrátil
On Feb. 16, 2014, 7:56 p.m., Martin Koller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115817/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2014, 7:56 p.m.)
>
>
> Review request for KDEPIM and Grégory Oestreicher.
>
>
> Repository: kdepim-runtime
>
>
> Description
> -------
>
> The DAV resource would discard item modifications (add, change, remove) whenever it does not currently reach the DAV server,
> which can happen when I'm connected to the company network but have a DAV server in my home network only.
>
> This patch makes sure to set the resource to offline in these cases and retries to go online at configured check interval.
>
>
> Diffs
> -----
>
> resources/dav/resource/davgroupwareresource.h a514c94
> resources/dav/resource/davgroupwareresource.cpp 36fb135
>
> Diff: https://git.reviewboard.kde.org/r/115817/diff/
>
>
> Testing
> -------
>
> Tested against my owncloud-6 server
>
>
> Thanks,
>
> Martin Koller
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list