[Kde-pim] Review Request 115769: Add KAccounts supoprt to the facebook resource

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115769/#review50044
-----------------------------------------------------------



resources/facebook/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115769/#comment35143>

    Uncomment?



resources/facebook/facebookresource.cpp
<https://git.reviewboard.kde.org/r/115769/#comment35150>

    We don't actually have this slot...do we need this connect then? I think that's why the exec is there, to make things simpler...



resources/facebook/facebookresource.cpp
<https://git.reviewboard.kde.org/r/115769/#comment35149>

    I wonder if this will block all of Akonadi...(it communicates over DBus internally, right?)



resources/shared/getcredentialsjob.h
<https://git.reviewboard.kde.org/r/115769/#comment35142>

    QObject* parent -> QObject *parent



resources/shared/getcredentialsjob.h
<https://git.reviewboard.kde.org/r/115769/#comment35148>

    I'm not sure if RB is actually showing it or not, but there's still no empty new line at the end of the file (both .h and .cpp ;)



resources/shared/getcredentialsjob.cpp
<https://git.reviewboard.kde.org/r/115769/#comment35144>

    Variable signs to the right -> const Accounts::AccountId &id, QObject *parent



resources/shared/getcredentialsjob.cpp
<https://git.reviewboard.kde.org/r/115769/#comment35145>

    SignOn::Identity* identity -> SignOn::Identity *identity



resources/shared/getcredentialsjob.cpp
<https://git.reviewboard.kde.org/r/115769/#comment35146>

    const SignOn::SessionData& data -> const SignOn::SessionData &data



resources/shared/getcredentialsjob.cpp
<https://git.reviewboard.kde.org/r/115769/#comment35147>

    const SignOn::Error& error -> const SignOn::Error &error


- Martin Klapetek


On Feb. 17, 2014, 3:47 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115769/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 3:47 p.m.)
> 
> 
> Review request for KDEPIM and Martin Klapetek.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Patch mostly made by mklapetek that makes use of webaccounts if present.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5f2ba59 
>   resources/facebook/CMakeLists.txt f24de9a 
>   resources/facebook/facebookresource.cpp 5f59018 
>   resources/facebook/facebookresource.desktop 80cec32 
>   resources/facebook/facebookresource.h 1b53f9a 
>   resources/facebook/settingsbase.kcfg 570a1fc 
>   resources/facebook/settingsdialog.cpp fc97f6d 
>   resources/shared/getcredentialsjob.h PRE-CREATION 
>   resources/shared/getcredentialsjob.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115769/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/