[Kde-pim] Review Request 116453: Coding Style for typepluginloader.cpp
Dan Vrátil
dvratil at redhat.com
Thu Feb 27 23:17:57 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116453/#review51211
-----------------------------------------------------------
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35926>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35928>
{} on a new line?
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35927>
Remove whitespace
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35929>
{ on a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35930>
{ on a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35931>
{ one a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35932>
Remove space before ";"
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35933>
{ on a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35934>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35935>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35936>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35937>
Please add {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35938>
Add {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35939>
Add {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35940>
{ on a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35941>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35942>
{ on a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35943>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35944>
Remove spaces after > and before <
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35945>
Move { on a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35946>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35947>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35948>
Wrong indentation (this belongs into the Q_FOREACH block)
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35949>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35950>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35951>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35952>
{ on a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35953>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35954>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35955>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35956>
Missing {]
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35957>
{ on a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35958>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35959>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35960>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35961>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35962>
{ on a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35963>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35964>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35965>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35966>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35967>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35968>
Missing {}
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35969>
{ on a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35970>
{ one a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35971>
{ one a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35972>
{ one a new line
akonadi/typepluginloader.cpp
<https://git.reviewboard.kde.org/r/116453/#comment35973>
{ on a new line
- Dan Vrátil
On Feb. 27, 2014, 6:56 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116453/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2014, 6:56 p.m.)
>
>
> Review request for KDEPIM-Libraries and Dan Vrátil.
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> Details can be seen at:
> http://techbase.kde.org/Policies/Kdepim_Coding_Style
>
>
> Diffs
> -----
>
> akonadi/typepluginloader.cpp 0ab600b
>
> Diff: https://git.reviewboard.kde.org/r/116453/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list