[Kde-pim] Review Request 115846: kontact summary view

[Kevin Krammer]

> On Feb. 19, 2014, 11:40 a.m., Laurent Montel wrote:
> > kontact/plugins/korganizer/apptsummarywidget.cpp, line 160
> > <https://git.reviewboard.kde.org/r/115846/diff/2/?file=244925#file244925line160>
> >
> >     I don't think it's a good idea to uppercase a i18n string.
> >     We need to use standard case for it.
> 
> Kevin Krammer wrote:
>     One of the calendar guys has to check this.
>     This is either a user visible string, in which case it needs translation and not be all uppercase, or it is an identifier, in which case it should not be translated
> 
> Christian Mollekopf wrote:
>     This is an identifier in a user visible field, so in general not a particularly good idea IMO. Translating it may or may not make sense, depending on wether you want the magic value to be translated or not.
> 
> Kevin Krammer wrote:
>     can the user edit those?
> 
> Eugenio Accorsi wrote:
>     yes, in korganizer there is an "edit categories".
>     some categories are automatically added by birthdays resource (but they are added translated).
>     maybe there is a better way to find out wich event are birthday.
>     looking at KDE-KABC-BIRTHDAY/ANNIVERSARY will exclude only birthday event created by the birthdays resource not birthday event added manually.

Right, using something user editable in a hard coded check doesn't sound viable at all.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115846/#review50211
-----------------------------------------------------------


On Feb. 19, 2014, 10:43 a.m., Eugenio Accorsi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115846/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 10:43 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 278956
>     http://bugs.kde.org/show_bug.cgi?id=278956
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> since i use kontact very often i tried to make the summary view work as expected.
> the only problem with this patch is the special event plugin.
> maybe someone with better experience with akonadi can steer me in the right direction..
> i changed the old implementation because it doesn't work for every contact.
> 
> 
> Diffs
> -----
> 
>   kontact/plugins/korganizer/apptsummaryconfig_base.ui 93e72bd 
>   kontact/plugins/korganizer/apptsummarywidget.h 95bfe3b 
>   kontact/plugins/korganizer/apptsummarywidget.cpp 33fff04 
>   kontact/plugins/korganizer/kcmapptsummary.h bddab14 
>   kontact/plugins/korganizer/kcmapptsummary.cpp 6a661a4 
>   kontact/plugins/korganizer/summaryeventinfo.h a9bb775 
>   kontact/plugins/korganizer/summaryeventinfo.cpp 00c9906 
>   kontact/plugins/specialdates/kcmsdsummary.h 778c389 
>   kontact/plugins/specialdates/kcmsdsummary.cpp 3b9c5a4 
>   kontact/plugins/specialdates/sdsummarywidget.h 9076c79 
>   kontact/plugins/specialdates/sdsummarywidget.cpp 67990c3 
> 
> Diff: https://git.reviewboard.kde.org/r/115846/diff/
> 
> 
> Testing
> -------
> 
> in the special-occasion plugin enabling the search for special events in contacts will result in high cpu usage by nepomuk.
> i tried also with master but it does not find any contacts.
> the summary event plugin works as expected.
> 
> 
> Thanks,
> 
> Eugenio Accorsi
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/