[Kde-pim] Review Request 114941: Coding Style for contacteditorwidget.cpp

[Kevin Krammer]

> On Feb. 6, 2014, 5:03 p.m., Kevin Krammer wrote:
> > akonadi/contact/editor/contacteditorwidget.cpp, line 532
> > <https://git.reviewboard.kde.org/r/114941/diff/4-5/?file=241384#file241384line532>
> >
> >     almost :)
> >     pass the parent on to the base class constructor.
> >     : AbstractContactEditorWidget(parent)
> 
> Guy Maurel wrote:
>     NO, says the compiler:
>     kdepimlibs/akonadi/contact/editor/contacteditorwidget.cpp:533:36: error: no matching function for call to 'Akonadi::AbstractContactEditorWidget::AbstractContactEditorWidget(QWidget*&)'
>          , d(new Private(FullMode, this))

Then the base class is missing the constructor that takes a QWidget*
Should look something like this
AbstractContactEditorWidget(QWidget *parent = 0)
and its implementation should forward the parent to the base class again.
Calling the parameterless constructor is what we already have, just explicit instead of implicit. It always discards the parent


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114941/#review49142
-----------------------------------------------------------


On Feb. 6, 2014, 4:51 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114941/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 4:51 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> # Using:
> astyle \
>     --indent=spaces --max-instatement-indent=80 --indent-cases \
>     --pad-header --pad-oper --unpad-paren \
>     --align-pointer=name --align-reference=name \
>     --max-instatement-indent=80 --min-conditional-indent=1 \
>     $1
> #
> # correct the SIGNAL and SLOT macros:
> normalize --modify $1
> #
> # change " & " to " &"
> gawk -f ${DIR}/Change-spaceANDspace.awk $1 > $1-a
> mv $1-a $1
> #
> # change "[ " to "[" and " ]" to "]"
> gawk -f ${DIR}/spaceInArray-change.awk ${WHERE} > ${WHERE}-k
> mv ${WHERE}-k ${WHERE}
> #
> # delete one line if two empties lines are present 
> gawk -f ${DIR}/Twice-change.awk $1 > $1-a
> mv $1-a $1
> #
> # delete first/last empty line(s)
> gawk -f ${DIR}/First-change.awk ${WHERE} > ${WHERE}-c
> mv ${WHERE}-c ${WHERE}
> #
> # lines with initialization(s)
> gawk -f ${DIR}/Default-1-change.awk < ${WHERE} > ${WHERE}-d1
> mv ${WHERE}-d1 ${WHERE}
> gawk -f ${DIR}/Default-2-change.awk < ${WHERE} > ${WHERE}-d2
> mv ${WHERE}-d2 ${WHERE}
> #
> # change <SPACE> after keyword
> ${DIR}/coding-style-change-SpaceAfter.sh ${WHERE}
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/editor/contacteditorwidget.cpp 50f67d2 
> 
> Diff: https://git.reviewboard.kde.org/r/114941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/