[Kde-pim] Review Request 116455: Coding Style for unlinkjob.cpp

Dan Vrátil dvratil at redhat.com
Thu Feb 27 23:03:49 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116455/#review51209
-----------------------------------------------------------



akonadi/unlinkjob.cpp
<https://git.reviewboard.kde.org/r/116455/#comment35925>

    I don't know what is the rule for methods with empty body, but for regular methods we put { and } each on separate line.



akonadi/unlinkjob.cpp
<https://git.reviewboard.kde.org/r/116455/#comment35922>

    Remove indentation



akonadi/unlinkjob.cpp
<https://git.reviewboard.kde.org/r/116455/#comment35921>

    Remove whitespace please



akonadi/unlinkjob.cpp
<https://git.reviewboard.kde.org/r/116455/#comment35923>

    Remove indentation



akonadi/unlinkjob.cpp
<https://git.reviewboard.kde.org/r/116455/#comment35924>

    Should be on the same line as ":"


- Dan Vrátil


On Feb. 27, 2014, 6:56 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116455/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 6:56 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/unlinkjob.cpp 51b168a 
> 
> Diff: https://git.reviewboard.kde.org/r/116455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list