[Kde-pim] mbox resource

[Martin Koller]

Hi,

I'm debugging the mbox resource and find a strange thing.
When I append a new message from the shell (simulating an external program appending a new message)
then SingleFileResourceBase::fileChanged() gets called which in turn lands in
MboxResource::writeToFile().
There the given filename is a temporary file, e.g. 
/home/kdetrunk/.kde4/share/apps/akonadi_mbox_resource_0/mbox-1
to which the whole current mbox file is copied via mMBox->save( fileName )

But then follows something I do not understand.
The comment in this file says something like
"... Therefore we
  // copy the original file and append pending changes to it but also add an extra
  // '\n' to make sure that the hashes differ and the user gets notified. ..."

But in fact it destroys what it has just written via
    QFile file( fileName );
    file.open( QIODevice::WriteOnly );
    file.seek( file.size() );
    file.write( "\n" );

QIODevice::WriteOnly is not QIODevice::WriteOnly|QIODevice::Append even with the seek()
so I assume that this is simply a bug, right ?

(but as I do not really understand what the comment shall tell me, maybe I'm wrong
and this does not matter ...)

Anybody can tell me if I'm wrong ?

-- 
Best regards/Schöne Grüße

Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?

()  ascii ribbon campaign - against html e-mail 
/\  www.asciiribbon.org   - against proprietary attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/