[Kde-pim] Review Request 115846: kontact summary view

[Christian Mollekopf]

On Wednesday 19 February 2014 12.48:59 Kevin Krammer wrote:
> > On Feb. 18, 2014, 4:49 p.m., Kevin Krammer wrote:
> > > kontact/plugins/korganizer/kcmapptsummary.cpp, line 42
> > > <https://git.reviewboard.kde.org/r/115846/diff/1/?file=244666#file244666
> > > line42>> > 
> > >     is this an unrelated change that crept into this diff?
> > 
> > Eugenio Accorsi wrote:
> >     i deleted that because they are not used, these variables are defined
> >     in the ui file.
> there might be objects with similar names, but at least mDaysButtonGroup
> might still be needed. It governs the exclusivness between three
> radiobuttons. Radio buttons do that themselves if they have the same
> parent, but they do not have the same parent, one of them has a different
> one.
> 
> I would prefer of you kept this exclusivness handling the way it is, just to
> be safe.
> 
> The other two might have been used to make connecting easier, i.e. connect
> to only one signal source instead of many. but at least they are not used
> for exclusinvess handling
> > On Feb. 18, 2014, 4:49 p.m., Kevin Krammer wrote:
> > > kontact/plugins/specialdates/sdsummarywidget.cpp, line 368
> > > <https://git.reviewboard.kde.org/r/115846/diff/1/?file=244670#file244670
> > > line368>> > 
> > >     does the comment no longer apply?
> > 
> > Eugenio Accorsi wrote:
> >     i think this check is to prevent the following case: one event from
> >     the KABC-BIRTHADY/ANNIVERSARY and one from the contact. but since i
> >     check it above i think that it's not needed anymore
> Ok. Needs verification by one of the calendar people :)
> 
> > On Feb. 18, 2014, 4:49 p.m., Kevin Krammer wrote:
> > > kontact/plugins/specialdates/sdsummarywidget.cpp, line 667
> > > <https://git.reviewboard.kde.org/r/115846/diff/1/?file=244670#file244670
> > > line667>> > 
> > >     Hmm. That will go through all contacts. I think the special job was
> > >     to prevent that, i.e. do not require tons of contacts to be loaded
> > >     that then do not contains birthday information> 
> > Eugenio Accorsi wrote:
> >     i changed it to fecth all contact now using a different approach and
> >     it's faster (but i have only ~100 contacts and so cannot test with
> >     more). the problem with the previous job is that i does not work
> >     every time for me (and also it is deprecated now).
> I guess ideally the old job would be extended to also query for contacts
> with anniversaries. The "problem" is that the used search provider is about
> to change in the next release and it uses a different query syntax. Lets
> see if we can get some help on this.
> 

Yes, please keep the job, I'll fix it.

Cheers,
Christian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/