[Kde-pim] Review Request 115807: Coding Style for specialmailcollectionsdiscoveryjob.h

[Kevin Krammer]

> On Feb. 16, 2014, 6:41 p.m., Kevin Krammer wrote:
> > akonadi/kmime/specialmailcollectionsdiscoveryjob.h, line 38
> > <https://git.reviewboard.kde.org/r/115807/diff/1/?file=244418#file244418line38>
> >
> >     I think files usually end with an empty line, no?
> 
> Guy Maurel wrote:
>     no.
>     I put it all the times away.

I think the empty line is the easiest way to ensure that the file ends in newline.
Which is something krazy checks for.
just make sure this does not trigger that check


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115807/#review49974
-----------------------------------------------------------


On Feb. 16, 2014, 4:50 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115807/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 4:50 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> # Using:
> astyle \
>     --indent=spaces --max-instatement-indent=80 --indent-cases \
>     --pad-header --pad-oper --unpad-paren \
>     --align-pointer=name --align-reference=name \
>     --max-instatement-indent=80 --min-conditional-indent=1 \
>     $1
> #
> # correct the SIGNAL and SLOT macros (under qt5/qtrepotools/util/normalize):
> normalize --modify $1
> #
> # add <SPACE> vor ": public"
> gawk -f ${DIR}/Public-change.awk ${WHERE} > ${WHERE}-p
> mv ${WHERE}-p ${WHERE}
> #
> # change " & " to " &"
> gawk -f ${DIR}/Change-spaceANDspace.awk $1 > $1-a
> mv $1-a $1
> #
> # change "[ " to "[" and " ]" to "]"
> gawk -f ${DIR}/spaceInArray-change.awk ${WHERE} > ${WHERE}-k
> mv ${WHERE}-k ${WHERE}
> #
> # delete one line if two empties lines are present 
> gawk -f ${DIR}/Twice-change.awk $1 > $1-a
> mv $1-a $1
> #
> # delete first/last empty line(s)
> gawk -f ${DIR}/First-change.awk ${WHERE} > ${WHERE}-c
> mv ${WHERE}-c ${WHERE}
> #
> # lines with initialization(s)
> gawk -f ${DIR}/Default-1-change.awk < ${WHERE} > ${WHERE}-d1
> mv ${WHERE}-d1 ${WHERE}
> gawk -f ${DIR}/Default-2-change.awk < ${WHERE} > ${WHERE}-d2
> mv ${WHERE}-d2 ${WHERE}
> #
> # change <SPACE> after keyword
> ${DIR}/coding-style-change-SpaceAfter.sh ${WHERE}
> 
> 
> Diffs
> -----
> 
>   akonadi/kmime/specialmailcollectionsdiscoveryjob.h 9095e53 
> 
> Diff: https://git.reviewboard.kde.org/r/115807/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/