[Kde-pim] Review Request 116478: Coding style fixes for Action.qml

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116478/#review51302
-----------------------------------------------------------


A couple of smaller improvement hints, but otherwise good work


Action.qml
<https://git.reviewboard.kde.org/r/116478/#comment36132>

    this is a marker for trailing whitespace, i.e. usually unneeded and unwanted space characters at the end of the line.
    Some editors even have settings to remove them automatically on save.



Action.qml
<https://git.reviewboard.kde.org/r/116478/#comment36133>

    this looks aligned with the line above, but should be indented (it is part of the body of the onReleased handler. see body of onPressed



Action.qml
<https://git.reviewboard.kde.org/r/116478/#comment36134>

    same here



Action.qml
<https://git.reviewboard.kde.org/r/116478/#comment36135>

    and here


- Kevin Krammer


On Feb. 28, 2014, 9:21 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116478/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 9:21 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Details at: 
> 
> https://community.kde.org/Plasma/QMLStyle 
> 
> 
> Diffs
> -----
> 
>   Action.qml 7f803fa 
> 
> Diff: https://git.reviewboard.kde.org/r/116478/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/