[Kde-pim] Review Request 113253: kimap: add methods to set/get the internal date for an APPEND query

[Wolfgang Bauer]

> On Feb. 25, 2014, 5:08 p.m., Christian Mollekopf wrote:
> > After updating the corresponding unittest and making sure all test pass you can commit it directly. Let me know if I should commit it for you (in that case I'll need the updated patch with unittest).

I can commit it myself, thanks. (I do have a developer account)

One more question regarding the unittest though, which puzzled me a bit:
For some reason the client seems to append an additional space character in the append request (right before the content size), which made my new test case fail at first.
I then noticed that this additional space is also there in the other test cases in the expected client request.
So I guess this is a problem with the test?
I added that additional space in my new test case as well, the test passes now.

I hope that's ok? And I hope the test in itself is ok, too.

I'm going to commit this later today, if there are no responses saying otherwise. (AFAIK today is API freeze)


- Wolfgang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113253/#review50835
-----------------------------------------------------------


On Feb. 26, 2014, 3:16 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113253/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 3:16 p.m.)
> 
> 
> Review request for KDEPIM and KDEPIM-Libraries.
> 
> 
> Bugs: 230635
>     http://bugs.kde.org/show_bug.cgi?id=230635
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This patch adds the methods AppendJob::setInternalDate() and AppendJob::internalDate().
> Those can be used to set the internal date for the APPEND command, see http://tools.ietf.org/html/rfc3501#section-6.3.11 .
> 
> If setInternalDate() is not called, the exact same query is generated as before, so existing users of AppendJob should not break.
> 
> This is needed to fix bug#230635, see https://git.reviewboard.kde.org/r/113254/
> 
> 
> Diffs
> -----
> 
>   kimap/appendjob.h d01f4f2 
>   kimap/appendjob.cpp a79181b 
>   kimap/tests/appendjobtest.cpp 5535f69 
> 
> Diff: https://git.reviewboard.kde.org/r/113253/diff/
> 
> 
> Testing
> -------
> 
> Copy a mail to an IMAP server (using KMail).
> 
> With the current (unpatched) kdepim-runtime, the APPEND still succeeds and the current date/time is used as internal date, i.e. there's no change in behaviour despite the patch.
> 
> With a kdepim-runtime that includes the patch from Review Request #113254 , the APPEND succeeds as well, the date/time as specified in the mail header is set.
> 
> I also ran akonadi with the KIMAP_LOGFILE environment variable set, and checked the resulting APPEND query string. In the first case it's exactly like before, in the second case a date/time string is added to the query respecting the RFC.
> 
> I'm using this (in combination with https://git.reviewboard.kde.org/r/113254/) since October without issues, everything's working as expected.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/