[Kde-pim] Review Request 115761: Fixed endless loop in changerecorder with unhandled notifications.

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115761/
-----------------------------------------------------------

Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

Fixed endless loop in changerecorder with unhandled notifications.

replayNext only peeked at the head of pendingNotifications, with the dequing happening
in changeProcessed after the notification has been processed by the client.
If noone handled the notifiation though, the code would automatically call replayNext again,
dispatching the same notification.

This patch puts the whole logic into one place (replayNext), and dequeues the notification
before calling replayNext again.

I noticed this in the tags2 branch because Akonadi::Observer doesn't yet implement the tag-related signals.


Diffs
-----

  akonadi/changerecorder.cpp 60d5107e81502ce62062649b6ab9330986512add 
  akonadi/changerecorder_p.h 873b5d6e15493b71250dac58fb4b827236d7ebc0 
  akonadi/changerecorder_p.cpp ac981bf79461b4ee073854085012b67962640640 

Diff: https://git.reviewboard.kde.org/r/115761/diff/


Testing
-------


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/