[Kde-pim] Review Request 114941: Coding Style for contacteditorwidget.cpp

[Kevin Krammer]

> On Feb. 6, 2014, 6:42 p.m., Kevin Krammer wrote:
> > akonadi/contact/abstractcontacteditorwidget_p.h, line 58
> > <https://git.reviewboard.kde.org/r/114941/diff/6/?file=242301#file242301line58>
> >
> >     the first argument is called contact also in the sub class, so why change?
> 
> Guy Maurel wrote:
>     because contacteditor.cpp 
>     declare it as addr at line 184
>     One of the two would be fine!
>     Which one do you prefer?

AbstractContactEditorWidget and its subclass ContactEditorWidget use contact, so lets keep those two consistent and don't change it. The method is also called loadContact() so "contact" makes most sense


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114941/#review49148
-----------------------------------------------------------


On Feb. 6, 2014, 6:16 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114941/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 6:16 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> # Using:
> astyle \
>     --indent=spaces --max-instatement-indent=80 --indent-cases \
>     --pad-header --pad-oper --unpad-paren \
>     --align-pointer=name --align-reference=name \
>     --max-instatement-indent=80 --min-conditional-indent=1 \
>     $1
> #
> # correct the SIGNAL and SLOT macros:
> normalize --modify $1
> #
> # change " & " to " &"
> gawk -f ${DIR}/Change-spaceANDspace.awk $1 > $1-a
> mv $1-a $1
> #
> # change "[ " to "[" and " ]" to "]"
> gawk -f ${DIR}/spaceInArray-change.awk ${WHERE} > ${WHERE}-k
> mv ${WHERE}-k ${WHERE}
> #
> # delete one line if two empties lines are present 
> gawk -f ${DIR}/Twice-change.awk $1 > $1-a
> mv $1-a $1
> #
> # delete first/last empty line(s)
> gawk -f ${DIR}/First-change.awk ${WHERE} > ${WHERE}-c
> mv ${WHERE}-c ${WHERE}
> #
> # lines with initialization(s)
> gawk -f ${DIR}/Default-1-change.awk < ${WHERE} > ${WHERE}-d1
> mv ${WHERE}-d1 ${WHERE}
> gawk -f ${DIR}/Default-2-change.awk < ${WHERE} > ${WHERE}-d2
> mv ${WHERE}-d2 ${WHERE}
> #
> # change <SPACE> after keyword
> ${DIR}/coding-style-change-SpaceAfter.sh ${WHERE}
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/abstractcontacteditorwidget_p.h 9cae6da 
>   akonadi/contact/editor/contacteditorwidget.cpp 50f67d2 
> 
> Diff: https://git.reviewboard.kde.org/r/114941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/