[Kde-pim] Review Request 115555: Coding Style for addresseditwidget.cpp

[Kevin Krammer]

> On Feb. 8, 2014, 6:24 p.m., Kevin Krammer wrote:
> > akonadi/contact/editor/addresseditwidget.cpp, line 73
> > <https://git.reviewboard.kde.org/r/115555/diff/1/?file=242679#file242679line73>
> >
> >     I know it is not part of the usual changes, but how about changing the C-style cast to a static_cast while we are at it?
> 
> Guy Maurel wrote:
>     a pretty question.
>     Could we take it over to the next task?

sure. it is not really necessary, just saw it and had the urge to change it :)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115555/#review49272
-----------------------------------------------------------


On Feb. 9, 2014, 5:13 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115555/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2014, 5:13 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> # Using:
> astyle \
>     --indent=spaces --max-instatement-indent=80 --indent-cases \
>     --pad-header --pad-oper --unpad-paren \
>     --align-pointer=name --align-reference=name \
>     --max-instatement-indent=80 --min-conditional-indent=1 \
>     $1
> #
> # correct the SIGNAL and SLOT macros (under qt5/qtrepotools/util/normalize):
> normalize --modify $1
> #
> # add <SPACE> vor ": public"
> gawk -f ${DIR}/Public-change.awk ${WHERE} > ${WHERE}-p
> mv ${WHERE}-p ${WHERE}
> #
> # change " & " to " &"
> gawk -f ${DIR}/Change-spaceANDspace.awk $1 > $1-a
> mv $1-a $1
> #
> # change "[ " to "[" and " ]" to "]"
> gawk -f ${DIR}/spaceInArray-change.awk ${WHERE} > ${WHERE}-k
> mv ${WHERE}-k ${WHERE}
> #
> # delete one line if two empties lines are present 
> gawk -f ${DIR}/Twice-change.awk $1 > $1-a
> mv $1-a $1
> #
> # delete first/last empty line(s)
> gawk -f ${DIR}/First-change.awk ${WHERE} > ${WHERE}-c
> mv ${WHERE}-c ${WHERE}
> #
> # lines with initialization(s)
> gawk -f ${DIR}/Default-1-change.awk < ${WHERE} > ${WHERE}-d1
> mv ${WHERE}-d1 ${WHERE}
> gawk -f ${DIR}/Default-2-change.awk < ${WHERE} > ${WHERE}-d2
> mv ${WHERE}-d2 ${WHERE}
> #
> # change <SPACE> after keyword
> ${DIR}/coding-style-change-SpaceAfter.sh ${WHERE}
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/editor/addresseditwidget.cpp cfdbab6 
> 
> Diff: https://git.reviewboard.kde.org/r/115555/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/