[Kde-pim] Review Request 115846: kontact summary view

[Eugenio Accorsi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115846/
-----------------------------------------------------------

(Updated Feb. 19, 2014, 10:43 a.m.)


Review request for KDEPIM.


Changes
-------

updated diff.
fixed an error in ui file.
instead of class contactsearchjob i used collectionfetchjob and itemfetchjob for sdsummarywidget.cpp
even if it load all contacts it seems fast (but i have only ~100 contacts).


Bugs: 278956
    http://bugs.kde.org/show_bug.cgi?id=278956


Repository: kdepim


Description
-------

since i use kontact very often i tried to make the summary view work as expected.
the only problem with this patch is the special event plugin.
maybe someone with better experience with akonadi can steer me in the right direction..
i changed the old implementation because it doesn't work for every contact.


Diffs (updated)
-----

  kontact/plugins/korganizer/apptsummaryconfig_base.ui 93e72bd 
  kontact/plugins/korganizer/apptsummarywidget.h 95bfe3b 
  kontact/plugins/korganizer/apptsummarywidget.cpp 33fff04 
  kontact/plugins/korganizer/kcmapptsummary.h bddab14 
  kontact/plugins/korganizer/kcmapptsummary.cpp 6a661a4 
  kontact/plugins/korganizer/summaryeventinfo.h a9bb775 
  kontact/plugins/korganizer/summaryeventinfo.cpp 00c9906 
  kontact/plugins/specialdates/kcmsdsummary.h 778c389 
  kontact/plugins/specialdates/kcmsdsummary.cpp 3b9c5a4 
  kontact/plugins/specialdates/sdsummarywidget.h 9076c79 
  kontact/plugins/specialdates/sdsummarywidget.cpp 67990c3 

Diff: https://git.reviewboard.kde.org/r/115846/diff/


Testing
-------

in the special-occasion plugin enabling the search for special events in contacts will result in high cpu usage by nepomuk.
i tried also with master but it does not find any contacts.
the summary event plugin works as expected.


Thanks,

Eugenio Accorsi

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/