[Kde-pim] Review Request 115769: Add KAccounts supoprt to the facebook resource

[Kevin Krammer]

> On Feb. 17, 2014, 10:57 a.m., Martin Klapetek wrote:
> > resources/shared/getcredentialsjob.cpp, line 89
> > <https://git.reviewboard.kde.org/r/115769/diff/3/?file=244513#file244513line89>
> >
> >     Do we need this printed if we're doing setErrorText (which I assume will get displayed somewhere)? The less debug output the better

I think we have this elsewhere as well.
The basic idea is that you have the log output mostly in the order of when things occured, while a user display (notification, etc) is kind of separated.


> On Feb. 17, 2014, 10:57 a.m., Martin Klapetek wrote:
> > resources/shared/getcredentialsjob.cpp, line 30
> > <https://git.reviewboard.kde.org/r/115769/diff/3/?file=244513#file244513line30>
> >
> >     The pointer signs should be next to the variable (it's correct in the .h)

same for the &


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115769/#review50028
-----------------------------------------------------------


On Feb. 17, 2014, 10:48 a.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115769/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 10:48 a.m.)
> 
> 
> Review request for KDEPIM and Martin Klapetek.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Patch mostly made by mklapetek that makes use of webaccounts if present.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5f2ba59 
>   resources/facebook/CMakeLists.txt f24de9a 
>   resources/facebook/facebookresource.cpp 5f59018 
>   resources/facebook/facebookresource.desktop 80cec32 
>   resources/facebook/facebookresource.h 1b53f9a 
>   resources/facebook/settingsbase.kcfg 570a1fc 
>   resources/facebook/settingsdialog.cpp fc97f6d 
>   resources/shared/getcredentialsjob.h PRE-CREATION 
>   resources/shared/getcredentialsjob.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115769/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/