[Kde-pim] Review Request 116417: Coding Style for subscriptionmodel.cpp

Dan Vrátil dvratil at redhat.com
Fri Feb 28 00:00:28 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116417/#review51248
-----------------------------------------------------------



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment35995>

    {} should be on new lines



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment35996>

    This entire block has wrong indentation



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment35997>

    Remove whitespace



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment35998>

    Wrong indentation



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment35999>

    Missing {}



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment36000>

    Missing {}



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment36001>

    Wrong indentation (belongs into the foreach block), missing {}



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment36002>

    Missing {} here and below



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment36003>

    Missing {}



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment36004>

    Missing {}



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment36005>

    Missing {}



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment36006>

    Missing {}



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment36007>

    Missing {}



akonadi/subscriptionmodel.cpp
<https://git.reviewboard.kde.org/r/116417/#comment36008>

    Missing {}


- Dan Vrátil


On Feb. 27, 2014, 6:52 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116417/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 6:52 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/subscriptionmodel.cpp 682ffcc 
> 
> Diff: https://git.reviewboard.kde.org/r/116417/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list