[Kde-pim] Review Request 115846: kontact summary view

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115846/#review50163
-----------------------------------------------------------



kontact/plugins/korganizer/apptsummarywidget.cpp
<https://git.reviewboard.kde.org/r/115846/#comment35265>

    Are you sure this needs to be translated?
    All uppercase strings look like identifiers to me, but I am not familiar with the underlying data type



kontact/plugins/korganizer/apptsummarywidget.cpp
<https://git.reviewboard.kde.org/r/115846/#comment35266>

    I guess you can remove that line then and use item.id() in places currently using id



kontact/plugins/korganizer/apptsummarywidget.cpp
<https://git.reviewboard.kde.org/r/115846/#comment35268>

    please use block braces {} around each branch's body



kontact/plugins/korganizer/apptsummarywidget.cpp
<https://git.reviewboard.kde.org/r/115846/#comment35267>

    please use block braces {} around each branch's body



kontact/plugins/korganizer/kcmapptsummary.cpp
<https://git.reviewboard.kde.org/r/115846/#comment35270>

    is this an unrelated change that crept into this diff?



kontact/plugins/korganizer/kcmapptsummary.cpp
<https://git.reviewboard.kde.org/r/115846/#comment35269>

    what is the reason for the value change here?



kontact/plugins/korganizer/summaryeventinfo.cpp
<https://git.reviewboard.kde.org/r/115846/#comment35271>

    see above



kontact/plugins/korganizer/summaryeventinfo.cpp
<https://git.reviewboard.kde.org/r/115846/#comment35272>

    please use block braces {} around branch's body



kontact/plugins/korganizer/summaryeventinfo.cpp
<https://git.reviewboard.kde.org/r/115846/#comment35273>

    I am not sure how expensive the getNextDateTime() call is but sinde the result is needed again later it might make sense to assign it to a local variable



kontact/plugins/specialdates/sdsummarywidget.cpp
<https://git.reviewboard.kde.org/r/115846/#comment35274>

    does the comment no longer apply?



kontact/plugins/specialdates/sdsummarywidget.cpp
<https://git.reviewboard.kde.org/r/115846/#comment35275>

    Hmm. That will go through all contacts. I think the special job was to prevent that, i.e. do not require tons of contacts to be loaded that then do not contains birthday information


- Kevin Krammer


On Feb. 17, 2014, 9:33 p.m., Eugenio Accorsi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115846/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 9:33 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 278956
>     http://bugs.kde.org/show_bug.cgi?id=278956
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> since i use kontact very often i tried to make the summary view work as expected.
> the only problem with this patch is the special event plugin.
> maybe someone with better experience with akonadi can steer me in the right direction..
> i changed the old implementation because it doesn't work for every contact.
> 
> 
> Diffs
> -----
> 
>   kontact/plugins/korganizer/apptsummaryconfig_base.ui 93e72bd 
>   kontact/plugins/korganizer/apptsummarywidget.h 95bfe3b 
>   kontact/plugins/korganizer/apptsummarywidget.cpp 33fff04 
>   kontact/plugins/korganizer/kcmapptsummary.h bddab14 
>   kontact/plugins/korganizer/kcmapptsummary.cpp 6a661a4 
>   kontact/plugins/korganizer/summaryeventinfo.h a9bb775 
>   kontact/plugins/korganizer/summaryeventinfo.cpp 00c9906 
>   kontact/plugins/specialdates/sdsummarywidget.h 9076c79 
>   kontact/plugins/specialdates/sdsummarywidget.cpp 67990c3 
> 
> Diff: https://git.reviewboard.kde.org/r/115846/diff/
> 
> 
> Testing
> -------
> 
> in the special-occasion plugin enabling the search for special events in contacts will result in high cpu usage by nepomuk.
> i tried also with master but it does not find any contacts.
> the summary event plugin works as expected.
> 
> 
> Thanks,
> 
> Eugenio Accorsi
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/