[Kde-pim] Review Request 121307: Add reviewboardrc file.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121307/
-----------------------------------------------------------

(Updated Dec. 8, 2014, 7:40 p.m.)


Review request for KDEPIM, Daniel Vrátil and Volker Krause.


Changes
-------

bug fixed, added a clear button, disabled custom context menu on text edit (much more useful to search, and copy stuff from it, then clearing it, now that we have a button for that), added context menu on the rest of the view to clear. the other ideas I had as well, but didn't implement yet


Summary (updated)
-----------------

Add reviewboardrc file.


Repository: kdepim


Description (updated)
-------

Add a list of queries to the top of the query debugger.

This list aggregates the query runtime and number of calls to the
query. This is much more useful, imo, than the text view below.

Note that this patch also disables the text view by default, as it
can easily lead to out-of-memory issues. Blindly appending lots
of text is bound to fail, sooner or later.

REVIEW: 121307


Diffs (updated)
-----

  .reviewboardrc PRE-CREATION 
  akonadiconsole/querydebugger.h 52b8a2d57501cd742dbc18516f83fe74bc7b19e0 
  akonadiconsole/querydebugger.cpp ac1d118a0a8eebb56521f50b5fb1e9b03dec47ff 

Diff: https://git.reviewboard.kde.org/r/121307/diff/


Testing
-------

it works!


File Attachments
----------------

screenshot of aggregation
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/01/a3b406a4-d03d-41dc-b198-4f2f304208cb__akonadiconsole_debugger.png


Thanks,

Milian Wolff

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/