[Kde-pim] Review Request 121242: Coding Style for addressattribute.cpp emptytrashcommand.cpp messagefolderattribute.cpp messagemodel.cpp messagestatus.cpp movetotrashcommand.cpp removeduplicatesjob.cpp specialmailcollections.cpp specialmailcollectionsrequestjob.cpp standardmailactionmanager.cpp util.cpp

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121242/#review71158
-----------------------------------------------------------



akonadi-mime/src/standardmailactionmanager.cpp
<https://git.reviewboard.kde.org/r/121242/#comment49717>

    Please keep all i18n() methods in this whole switch statement with the same indentation.
    
    For instance this and the i18n call on l. 185 are indented differently, which makes it harder to read.
    
    Same applies on all the i18n changes below.


- Daniel Vrátil


On Nov. 25, 2014, 3:51 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121242/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2014, 3:51 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Daniel Vrátil, Kevin Krammer, Laurent Montel, and Tobias Koenig.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi-mime/src/addressattribute.cpp c9d836b 
>   akonadi-mime/src/emptytrashcommand.cpp 23ae88e 
>   akonadi-mime/src/messagefolderattribute.cpp ad40353 
>   akonadi-mime/src/messagemodel.cpp e4e2ca6 
>   akonadi-mime/src/messagestatus.cpp b9fa2fa 
>   akonadi-mime/src/movetotrashcommand.cpp 5a641a0 
>   akonadi-mime/src/removeduplicatesjob.cpp 239177b 
>   akonadi-mime/src/specialmailcollections.cpp 1583e09 
>   akonadi-mime/src/specialmailcollectionsrequestjob.cpp afdec8e 
>   akonadi-mime/src/standardmailactionmanager.cpp dda35b3 
>   akonadi-mime/src/util.cpp d6404b8 
> 
> Diff: https://git.reviewboard.kde.org/r/121242/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/